Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 362833004: return early instead of crashing if fileData fails (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
Reviewers:
krajcevski
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

return early instead of crashing if fileData fails BUG=skia: Committed: https://skia.googlesource.com/skia/+/7a7c3163f038cf4e24334f010c5ceab540a9f4be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/KtxTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
6 years, 5 months ago (2014-07-01 20:09:19 UTC) #1
krajcevski
On 2014/07/01 20:09:19, reed1 wrote: lgtm
6 years, 5 months ago (2014-07-01 22:36:04 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-02 12:45:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/362833004/1
6 years, 5 months ago (2014-07-02 12:46:00 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 12:57:54 UTC) #5
Message was sent while issue was closed.
Change committed as 7a7c3163f038cf4e24334f010c5ceab540a9f4be

Powered by Google App Engine
This is Rietveld 408576698