tests/KtxTest.cpp - Issue 362833004: return early instead of crashing if fileData fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/KtxTest.cpp

Issue 362833004: return early instead of crashing if fileData fails (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/KtxTest.cpp

diff --git a/tests/KtxTest.cpp b/tests/KtxTest.cpp

index 83a3546bec18281f134a0433dcaebb9704b9dad7..bddd09abbfe005665546eb4522237ce2bf49e50e 100644

--- a/tests/KtxTest.cpp

+++ b/tests/KtxTest.cpp

@@ -147,6 +147,9 @@ DEF_TEST(KtxReexportPKM, reporter) {

SkBitmap etcBitmap;

SkAutoTUnref<SkData> fileData(SkData::NewFromFileName(pkmFilename.c_str()));

REPORTER_ASSERT(reporter, NULL != fileData);

+ if (NULL == fileData) {

+ return;

+ }

bool installDiscardablePixelRefSuccess =

SkInstallDiscardablePixelRef(

« no previous file with comments | « no previous file | no next file » | no next file with comments »