Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 362773002: Rename SkPicturePlayback to SkPictureData (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rename SkPicturePlayback to SkPictureData This is in preparation for splitting the playback portion of the new SkPictureData class into a new SkPicturePlayback class. Committed: https://skia.googlesource.com/skia/+/db539905bb3af7bd05839a7d2558e97d5cb51ca2

Patch Set 1 #

Patch Set 2 : Fix include order #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -2555 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 4 chunks +11 lines, -11 lines 2 comments Download
M gyp/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 3 chunks +7 lines, -9 lines 0 comments Download
M src/core/SkPicture.cpp View 14 chunks +51 lines, -51 lines 0 comments Download
A + src/core/SkPictureData.h View 4 chunks +12 lines, -12 lines 0 comments Download
A + src/core/SkPictureData.cpp View 40 chunks +71 lines, -71 lines 0 comments Download
D src/core/SkPicturePlayback.h View 1 chunk +0 lines, -437 lines 0 comments Download
D src/core/SkPicturePlayback.cpp View 1 chunk +0 lines, -1935 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPictureUtils.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M tests/PictureTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/LazyDecodeBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/filtermain.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/skpinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-01 14:13:04 UTC) #1
mtklein
lgtm https://codereview.chromium.org/362773002/diff/20001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/362773002/diff/20001/debugger/QT/SkDebuggerGUI.cpp#newcode161 debugger/QT/SkDebuggerGUI.cpp:161: class SkTimedPicturePlayback : public SkPictureData { I take ...
6 years, 5 months ago (2014-07-01 14:19:49 UTC) #2
mtklein
lgtm
6 years, 5 months ago (2014-07-01 14:19:50 UTC) #3
robertphillips
https://codereview.chromium.org/362773002/diff/20001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/362773002/diff/20001/debugger/QT/SkDebuggerGUI.cpp#newcode161 debugger/QT/SkDebuggerGUI.cpp:161: class SkTimedPicturePlayback : public SkPictureData { Yep. It is ...
6 years, 5 months ago (2014-07-01 14:22:09 UTC) #4
reed1
lgtm
6 years, 5 months ago (2014-07-01 15:09:20 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-01 15:31:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/362773002/20001
6 years, 5 months ago (2014-07-01 15:31:21 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 15:47:08 UTC) #8
Message was sent while issue was closed. 
Change committed as db539905bb3af7bd05839a7d2558e97d5cb51ca2

Powered by Google App Engine
This is Rietveld 408576698