components/signin/core/browser/signin_manager.cc - Issue 362613002: Implementation of SigninClient::GetSigninScopedDeviceId

Unified Diff: components/signin/core/browser/signin_manager.cc

Issue 362613002: Implementation of SigninClient::GetSigninScopedDeviceId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « components/signin/core/browser/signin_client.h ('k') | components/signin/core/browser/signin_oauth_helper.cc » ('j') | components/signin/core/browser/signin_oauth_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/signin_manager.cc

diff --git a/components/signin/core/browser/signin_manager.cc b/components/signin/core/browser/signin_manager.cc

index 144242615a9b0fc851069d0c4d50a095e4733b06..9c68eb98915ca9b5c5c0d78a990e7c1bd2ac50b0 100644

--- a/components/signin/core/browser/signin_manager.cc

+++ b/components/signin/core/browser/signin_manager.cc

@@ -203,6 +203,7 @@ void SigninManager::SignOut(

const std::string username = GetAuthenticatedUsername();

clear_authenticated_username();

client_->GetPrefs()->ClearPref(prefs::kGoogleServicesUsername);

+ client_->ClearSigninScopedDeviceId();

pavely 2014/06/30 23:31:09 This is where id is cleared on signout.

Roger Tawa OOO till Jul 10th 2014/07/01 13:42:54 I wonder if it would be better to have a SignOut()

pavely 2014/07/01 21:41:47 I wanted to clear device id right before signing i

Roger Tawa OOO till Jul 10th 2014/07/03 15:07:41 sgtm

// Erase (now) stale information from AboutSigninInternals.

NotifyDiagnosticsObservers(USERNAME, "");