Implementation of SigninClient::GetSigninScopedDeviceId

components/signin/core/browser/signin_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/signin_manager.h"
 
 #include <string>
 #include <vector>
 
 #include "base/prefs/pref_service.h"
@@ skipping 185 matching lines @@
   if (prohibit_signout_) {
     DVLOG(1) << "Ignoring attempt to sign out while signout is prohibited";
     return;
   }
 
   ClearTransientSigninData();
 
   const std::string username = GetAuthenticatedUsername();
   clear_authenticated_username();
   client_->GetPrefs()->ClearPref(prefs::kGoogleServicesUsername);
+  client_->ClearSigninScopedDeviceId();

[pavely, 2014/06/30 23:31:09]

This is where id is cleared on signout.

[Roger Tawa OOO till Jul 10th, 2014/07/01 13:42:54]

I wonder if it would be better to have a SignOut() method in client_ and move
all the pref clearing to there.

[pavely, 2014/07/01 21:41:47]

I wanted to clear device id right before signing in so separate method is
needed. I removed this code for now, but I'll keep looking if there is a good
place to call it before sign-in.

Also I think knowing to clear kGoogleServicesUsername is signin_manager's
responsibility, signin_client just provides means to do things without
introducing dependency on chrome/browser/... code.

I think it should stay the way it is now.

On 2014/07/01 13:42:54, Roger Tawa wrote:

[Roger Tawa OOO till Jul 10th, 2014/07/03 15:07:41]

sgtm

 
   // Erase (now) stale information from AboutSigninInternals.
   NotifyDiagnosticsObservers(USERNAME, "");
 
   // Revoke all tokens before sending signed_out notification, because there
   // may be components that don't listen for token service events when the
   // profile is not connected to an account.
   LOG(WARNING) << "Revoking refresh token on server. Reason: sign out, "
                << "IsSigninAllowed: " << IsSigninAllowed();
   token_service_->RevokeAllCredentials();
@@ skipping 148 matching lines @@
 
   password_.clear();                           // Don't need it anymore.
   DisableOneClickSignIn(client_->GetPrefs());  // Don't ever offer again.
 }
 
 void SigninManager::ProhibitSignout(bool prohibit_signout) {
   prohibit_signout_ = prohibit_signout;
 }
 
 bool SigninManager::IsSignoutProhibited() const { return prohibit_signout_; }