Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/libaddressinput/libaddressinput.gyp

Issue 362583002: Add more GN deps to the build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix libaddressinput include path Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/libaddressinput.gyp
diff --git a/third_party/libaddressinput/libaddressinput.gyp b/third_party/libaddressinput/libaddressinput.gyp
index fc3fb930811dad83928c9f942ef09db6450b37a0..bc6e447445fe5bca9ba03d67ad51793281fa8806 100644
--- a/third_party/libaddressinput/libaddressinput.gyp
+++ b/third_party/libaddressinput/libaddressinput.gyp
@@ -21,6 +21,7 @@
},
'targets': [
{
+ # GN version: //third_party/libaddressinput:strings
'target_name': 'libaddressinput_strings',
'type': 'none',
'variables': {
@@ -42,6 +43,7 @@
],
},
{
+ # GN version: //third_party/libaddressinput:updated_strings
'target_name': 'libaddressinput_updated_strings',
'type': 'none',
'variables': {
@@ -63,7 +65,9 @@
],
},
# This target provides basic functionality which is cooked into the build.
- { 'target_name': 'libaddressinput_util',
+ {
+ # GN version: //third_party/libaddressinput:util
+ 'target_name': 'libaddressinput_util',
'type': 'static_library',
'include_dirs': [
'<(libaddressinput_dir)/cpp/include/',
@@ -112,6 +116,7 @@
# This target provides more complicated functionality like pinging servers
# for validation rules.
{
+ # GN version: //third_party/libaddressinput
'target_name': 'libaddressinput',
'type': 'static_library',
'include_dirs': [
@@ -169,6 +174,7 @@
},
},
{
+ # GN version: //third_party/libaddressinput:libaddressinput_unittests
awong 2014/07/01 21:47:11 Are add a comment now to tag each gyp target with
brettw 2014/07/01 23:26:27 Yes, so you can tell that it exists.
'target_name': 'libaddressinput_unittests',
'type': '<(gtest_target_type)',
'include_dirs': [

Powered by Google App Engine
This is Rietveld 408576698