tools/perf/metrics/cpu_unittest.py - Issue 362533003: Fix overflow for 32-bit jiffie counter on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/cpu_unittest.py

Issue 362533003: Fix overflow for 32-bit jiffie counter on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unittests for the overflow. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/cpu_unittest.py

diff --git a/tools/perf/metrics/cpu_unittest.py b/tools/perf/metrics/cpu_unittest.py

index 30d488dac8bc420399e00f32ea8a6fff6b8277d0..a6f4e30ed3904010eb3ba840f80bb5f388ac0c17 100644

--- a/tools/perf/metrics/cpu_unittest.py

+++ b/tools/perf/metrics/cpu_unittest.py

@@ -31,3 +31,9 @@ class CpuMetricTest(unittest.TestCase):

self.assertEqual({'Browser': 0.25, 'Renderer': 0.1},

cpu._SubtractCpuStats(end, start))

+ # Test 32-bit overflow

Sami 2014/06/30 16:25:16 nit: Add '.' at end.

+ start = {'Browser': {'CpuProcessTime': 0, 'TotalTime': 2**32 - 20}}

+ end = {'Browser': {'CpuProcessTime': 5, 'TotalTime': 20}}

+ self.assertEqual({'Browser': 0.125}, cpu._SubtractCpuStats(end, start))

+ self.assertRaises(AssertionError, cpu._SubtractCpuStats, start, end)

« no previous file with comments | « tools/perf/metrics/cpu.py ('k') | no next file » | no next file with comments »