Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: tools/perf/metrics/cpu_unittest.py

Issue 362533003: Fix overflow for 32-bit jiffie counter on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unittests for the overflow. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/metrics/cpu.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import unittest 5 import unittest
6 6
7 from metrics import cpu 7 from metrics import cpu
8 8
9 # Testing private method. 9 # Testing private method.
10 # pylint: disable=W0212 10 # pylint: disable=W0212
(...skipping 13 matching lines...) Expand all
24 24
25 # A process type will be ignored if there's an empty dict for start or end. 25 # A process type will be ignored if there's an empty dict for start or end.
26 start['Renderer'] = {} 26 start['Renderer'] = {}
27 self.assertEqual({'Browser': 0.25}, cpu._SubtractCpuStats(end, start)) 27 self.assertEqual({'Browser': 0.25}, cpu._SubtractCpuStats(end, start))
28 28
29 # Results for multiple process types can be computed. 29 # Results for multiple process types can be computed.
30 start['Renderer'] = {'CpuProcessTime': 0, 'TotalTime': 0} 30 start['Renderer'] = {'CpuProcessTime': 0, 'TotalTime': 0}
31 self.assertEqual({'Browser': 0.25, 'Renderer': 0.1}, 31 self.assertEqual({'Browser': 0.25, 'Renderer': 0.1},
32 cpu._SubtractCpuStats(end, start)) 32 cpu._SubtractCpuStats(end, start))
33 33
34 # Test 32-bit overflow
Sami 2014/06/30 16:25:16 nit: Add '.' at end.
35 start = {'Browser': {'CpuProcessTime': 0, 'TotalTime': 2**32 - 20}}
36 end = {'Browser': {'CpuProcessTime': 5, 'TotalTime': 20}}
37 self.assertEqual({'Browser': 0.125}, cpu._SubtractCpuStats(end, start))
38 self.assertRaises(AssertionError, cpu._SubtractCpuStats, start, end)
39
OLDNEW
« no previous file with comments | « tools/perf/metrics/cpu.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698