Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 362403002: Fix uninitialized nresults and RGB (Closed)

Created:
6 years, 5 months ago by jun_fang
Modified:
6 years, 5 months ago
Reviewers:
palmer
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix uninitialized nresults and RGB BUG=387785 R=palmer@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f3227ae

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -1 line 2 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jun_fang
6 years, 5 months ago (2014-07-02 19:09:57 UTC) #1
palmer
https://codereview.chromium.org/362403002/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right): https://codereview.chromium.org/362403002/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp#newcode1031 core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:1031: m_pFunc->Call(pBuf, m_nComponents, results, nresults); The way |nresults| is/was used ...
6 years, 5 months ago (2014-07-07 18:29:19 UTC) #2
palmer
LGTM. https://codereview.chromium.org/362403002/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right): https://codereview.chromium.org/362403002/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp#newcode1031 core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:1031: m_pFunc->Call(pBuf, m_nComponents, results, nresults); Ohh, I see, it's ...
6 years, 5 months ago (2014-07-07 18:39:10 UTC) #3
jun_fang
6 years, 5 months ago (2014-07-07 21:04:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as rf3227ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698