Fix uninitialized nresults and RGB

core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp

Index: core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp
diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp
index ff44c591c73322e22edb1b8a89cbb1b0040862a8..ea91587c6531298d95cae2ca40e3f90383c341ce 100644
--- a/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp
+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp
@@ -1027,7 +1027,7 @@ FX_BOOL CPDF_DeviceNCS::GetRGB(FX_FLOAT* pBuf, FX_FLOAT& R, FX_FLOAT& G, FX_FLOA
         return FALSE;
     }
     CFX_FixedBufGrow<FX_FLOAT, 16> results(m_pFunc->CountOutputs());
-    int nresults;
+    int nresults = 0;
     m_pFunc->Call(pBuf, m_nComponents, results, nresults);

[palmer, 2014/07/07 18:29:19]

The way |nresults| is/was used makes me wonder if it is supposed to be an
out-param. I.e  should you be calling like this:

    m_pFunc->Call(pBuf, m_nComponents, results, &nresults);

? Because as it is now, this function will always return FALSE and lines 1035 –
1036 are dead code.

[palmer, 2014/07/07 18:39:10]

Ohh, I see, it's a non-const reference. Carry on then...

     if (nresults == 0) {
         return FALSE;