Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 362313002: Precisely sweep scan on scavenge pages and use heap iterator to iterate over them. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)
Modified:
6 years, 5 months ago
Reviewers:
Jarin, rmcilroy
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Precisely sweep scan on scavenge pages and use heap iterator to iterate over them. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22154

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M src/mark-compact.cc View 1 chunk +16 lines, -5 lines 0 comments Download
M src/store-buffer.cc View 1 chunk +15 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-02 11:44:10 UTC) #1
Jarin
lgtm
6 years, 5 months ago (2014-07-02 12:11:14 UTC) #2
Hannes Payer (out of office)
Committed patchset #1 manually as r22154 (presubmit successful).
6 years, 5 months ago (2014-07-02 12:19:09 UTC) #3
rmcilroy
lgtm https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc#newcode560 src/store-buffer.cc:560: // We skip filler, free space, and constant ...
6 years, 5 months ago (2014-07-02 12:39:07 UTC) #4
rmcilroy
6 years, 5 months ago (2014-07-02 12:39:31 UTC) #5
Message was sent while issue was closed.
On 2014/07/02 12:39:07, rmcilroy wrote:
> lgtm
> 
> https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc
> File src/store-buffer.cc (right):
> 
>
https://codereview.chromium.org/362313002/diff/1/src/store-buffer.cc#newcode560
> src/store-buffer.cc:560: // We skip filler, free space, and constant pool
> objects.
> Could you add back the old comment here please:
> 
> // Skip fillers, free space, and constant pool arrays (which never 
> // contain new-space pointers but can contain pointers which can 
> // be confused for fillers).

Ahh, I see I missed the boat - never mind with the comment then.

Powered by Google App Engine
This is Rietveld 408576698