Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: src/store-buffer.cc

Issue 362313002: Precisely sweep scan on scavenge pages and use heap iterator to iterate over them. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mark-compact.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/store-buffer.cc
diff --git a/src/store-buffer.cc b/src/store-buffer.cc
index 4ab5c33c8cc439b59033c85c4be1ae5b92c67d49..e4cef27b4a5433d71e934425247767216aebbb02 100644
--- a/src/store-buffer.cc
+++ b/src/store-buffer.cc
@@ -552,8 +552,21 @@ void StoreBuffer::IteratePointersToNewSpace(ObjectSlotCallback slot_callback,
FindPointersToNewSpaceInMapsRegion(
start, end, slot_callback, clear_maps);
} else {
- FindPointersToNewSpaceInRegion(
- start, end, slot_callback, clear_maps);
+ ASSERT(page->WasSweptPrecisely());
+ HeapObjectIterator iterator(page, NULL);
+ for (HeapObject* heap_object = iterator.Next();
+ heap_object != NULL;
+ heap_object = iterator.Next()) {
+ // We skip filler, free space, and constant pool objects.
rmcilroy 2014/07/02 12:39:07 Could you add back the old comment here please: /
+ if (!heap_object->IsFiller() &&
+ !heap_object->IsConstantPoolArray()) {
+ FindPointersToNewSpaceInRegion(
+ heap_object->address() + HeapObject::kHeaderSize,
+ heap_object->address() + heap_object->Size(),
+ slot_callback,
+ clear_maps);
+ }
+ }
}
}
}
« no previous file with comments | « src/mark-compact.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698