Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 362073002: cc: Remove all traces of SkPicture cloning. (Closed)

Created:
6 years, 5 months ago by reveman
Modified:
6 years, 4 months ago
Reviewers:
mtklein_C, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Remove all traces of SkPicture cloning. Skia no longer require SkPictures to be cloned for playback on different threads. This removes all compositor code that exists only to handle the cloning requirement. BUG=235280 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291350

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -439 lines) Patch
M cc/debug/picture_record_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M cc/output/direct_renderer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 chunks +3 lines, -46 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/renderer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 3 chunks +2 lines, -46 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/picture.h View 1 2 7 chunks +1 line, -14 lines 0 comments Download
M cc/resources/picture.cc View 1 2 5 chunks +4 lines, -52 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M cc/resources/picture_pile.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/picture_pile_base.h View 1 2 4 chunks +4 lines, -6 lines 0 comments Download
M cc/resources/picture_pile_base.cc View 1 2 5 chunks +5 lines, -35 lines 0 comments Download
M cc/resources/picture_pile_impl.h View 1 6 chunks +16 lines, -40 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 1 12 chunks +16 lines, -50 lines 0 comments Download
M cc/resources/picture_pile_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_unittest.cc View 12 chunks +2 lines, -14 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 4 chunks +12 lines, -19 lines 0 comments Download
M cc/surfaces/display.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/pixel_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/pixel_test.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 7 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
reveman
Please take a look.
6 years, 4 months ago (2014-08-21 02:46:35 UTC) #1
mtklein_C
lgtm
6 years, 4 months ago (2014-08-21 14:53:30 UTC) #2
enne (OOO)
This is super exciting! lgtm
6 years, 4 months ago (2014-08-21 17:27:17 UTC) #3
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 4 months ago (2014-08-21 17:35:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/362073002/20001
6 years, 4 months ago (2014-08-21 17:36:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 21:29:28 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 21:36:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/56004) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44903) win_gpu ...
6 years, 4 months ago (2014-08-21 21:36:01 UTC) #8
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 4 months ago (2014-08-22 00:12:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/362073002/40001
6 years, 4 months ago (2014-08-22 00:13:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 01:57:11 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:00:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8329)
6 years, 4 months ago (2014-08-22 02:00:12 UTC) #13
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 4 months ago (2014-08-22 02:11:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/362073002/40001
6 years, 4 months ago (2014-08-22 02:11:56 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 07:24:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291350

Powered by Google App Engine
This is Rietveld 408576698