Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: cc/output/software_renderer.cc

Issue 362073002: cc: Remove all traces of SkPicture cloning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/renderer.h ('k') | cc/output/software_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/software_renderer.cc
diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc
index aaa951c2ae35f48047112c20fc0d19f5235ad16a..88b9c646c924956c054074ad6d7c804442a2fdd5 100644
--- a/cc/output/software_renderer.cc
+++ b/cc/output/software_renderer.cc
@@ -20,7 +20,6 @@
#include "cc/quads/solid_color_draw_quad.h"
#include "cc/quads/texture_draw_quad.h"
#include "cc/quads/tile_draw_quad.h"
-#include "cc/resources/raster_worker_pool.h"
#include "skia/ext/opacity_draw_filter.h"
#include "third_party/skia/include/core/SkBitmapDevice.h"
#include "third_party/skia/include/core/SkCanvas.h"
@@ -34,46 +33,8 @@
#include "ui/gfx/transform.h"
namespace cc {
-
namespace {
-class OnDemandRasterTaskImpl : public Task {
- public:
- OnDemandRasterTaskImpl(PicturePileImpl* picture_pile,
- SkCanvas* canvas,
- gfx::Rect content_rect,
- float contents_scale)
- : picture_pile_(picture_pile),
- canvas_(canvas),
- content_rect_(content_rect),
- contents_scale_(contents_scale) {
- DCHECK(picture_pile_);
- DCHECK(canvas_);
- }
-
- // Overridden from Task:
- virtual void RunOnWorkerThread() OVERRIDE {
- TRACE_EVENT0("cc", "OnDemandRasterTaskImpl::RunOnWorkerThread");
-
- PicturePileImpl* picture_pile = picture_pile_->GetCloneForDrawingOnThread(
- RasterWorkerPool::GetPictureCloneIndexForCurrentThread());
- DCHECK(picture_pile);
-
- picture_pile->RasterDirect(canvas_, content_rect_, contents_scale_, NULL);
- }
-
- protected:
- virtual ~OnDemandRasterTaskImpl() {}
-
- private:
- PicturePileImpl* picture_pile_;
- SkCanvas* canvas_;
- const gfx::Rect content_rect_;
- const float contents_scale_;
-
- DISALLOW_COPY_AND_ASSIGN(OnDemandRasterTaskImpl);
-};
-
static inline bool IsScalarNearlyInteger(SkScalar scalar) {
return SkScalarNearlyZero(scalar - SkScalarRoundToScalar(scalar));
}
@@ -389,13 +350,8 @@ void SoftwareRenderer::DrawPictureQuad(const DrawingFrame* frame,
TRACE_EVENT0("cc",
"SoftwareRenderer::DrawPictureQuad");
- // Create and run on-demand raster task for tile.
- scoped_refptr<Task> on_demand_raster_task(
- new OnDemandRasterTaskImpl(quad->picture_pile,
- current_canvas_,
- quad->content_rect,
- quad->contents_scale));
- client_->RunOnDemandRasterTask(on_demand_raster_task.get());
+ quad->picture_pile->RasterDirect(
+ current_canvas_, quad->content_rect, quad->contents_scale, NULL);
current_canvas_->setDrawFilter(NULL);
}
« no previous file with comments | « cc/output/renderer.h ('k') | cc/output/software_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698