Add support in smoke for generating static configurations in pieces.

Add support in smoke for generating static configurations in pieces.

R=jakemac@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38563

[Siggi Cherem (dart-lang), 2014-07-01 19:44:12]

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/test/piece2.dart
File pkg/smoke/test/piece2.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/test/piece2.da...
pkg/smoke/test/piece2.dart:27: #k: const Declaration(#k, int, annotations: const
[const smoke_0.AnnotC(named: true)]),
FYI - I'm just coping this line and the code in the next file from generated
code (code in static_test.dart is generated). I rather keep them equal instead
of wrapping the code here.

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/test/static_in...
File pkg/smoke/test/static_in_pieces_test.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/test/static_in...
pkg/smoke/test/static_in_pieces_test.dart:94:
configuration.addAll(p2.configuration);
this shows one way to load a configuration lazily with deferred imports.

[jakemac, 2014-07-23 20:05:02]

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/CHANGELOG.md
File pkg/smoke/CHANGELOG.md (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/CHANGELOG.md#n...
pkg/smoke/CHANGELOG.md:5: #### Pub version 0.2.0-dev
Should this be -pre if you are releasing it? I am still a bit confused on these.

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/codegen/ge...
File pkg/smoke/lib/codegen/generator.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/codegen/ge...
pkg/smoke/lib/codegen/generator.dart:254: ..write('${spaces}checkedMode:
false');
I think technically these ..'s should line up

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/static.dart
File pkg/smoke/lib/static.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/static.dar...
pkg/smoke/lib/static.dart:77: a.putIfAbsent(key, () => {});
So is this not inserting a null? It seems like there must be some magic going on
where its inserting a new object using the default constructor? Or maybe I am
just missing something here.

[Siggi Cherem (dart-lang), 2014-07-23 20:37:14]

thanks Jake!

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/CHANGELOG.md
File pkg/smoke/CHANGELOG.md (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/CHANGELOG.md#n...
pkg/smoke/CHANGELOG.md:5: #### Pub version 0.2.0-dev
On 2014/07/23 20:05:02, jakemac wrote:
> Should this be -pre if you are releasing it? I am still a bit confused on
these.

For now I think I don't plan to pre-release it yet. If we do, we can create a
tiny CL that updates it to -pre.0 and publish it at that moment.

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/codegen/ge...
File pkg/smoke/lib/codegen/generator.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/codegen/ge...
pkg/smoke/lib/codegen/generator.dart:254: ..write('${spaces}checkedMode:
false');
On 2014/07/23 20:05:02, jakemac wrote:
> I think technically these ..'s should line up

we have debated a bit about it in the past - the styleguide requires +4 spaces
of indentation and optionally extra spaces to line things up, but so far we have
preferred to keep it with just +4.

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/static.dart
File pkg/smoke/lib/static.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/static.dar...
pkg/smoke/lib/static.dart:77: a.putIfAbsent(key, () => {});
On 2014/07/23 20:05:02, jakemac wrote:
> So is this not inserting a null? It seems like there must be some magic going
on
> where its inserting a new object using the default constructor? Or maybe I am
> just missing something here.

Yeah, it's confusing because we have both => and {}, the {} here is an empty
map. To be more precise:

() {}      // returns null
() => null // equivalent closure.
() => {}   // returns a new map :-)

[jakemac, 2014-07-23 20:40:51]

lgtm

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/CHANGELOG.md
File pkg/smoke/CHANGELOG.md (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/CHANGELOG.md#n...
pkg/smoke/CHANGELOG.md:5: #### Pub version 0.2.0-dev
On 2014/07/23 20:37:13, Siggi Cherem (dart-lang) wrote:
> On 2014/07/23 20:05:02, jakemac wrote:
> > Should this be -pre if you are releasing it? I am still a bit confused on
> these.
> 
> For now I think I don't plan to pre-release it yet. If we do, we can create a
> tiny CL that updates it to -pre.0 and publish it at that moment.

Acknowledged.

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/codegen/ge...
File pkg/smoke/lib/codegen/generator.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/codegen/ge...
pkg/smoke/lib/codegen/generator.dart:254: ..write('${spaces}checkedMode:
false');
On 2014/07/23 20:37:13, Siggi Cherem (dart-lang) wrote:
> On 2014/07/23 20:05:02, jakemac wrote:
> > I think technically these ..'s should line up
> 
> we have debated a bit about it in the past - the styleguide requires +4 spaces
> of indentation and optionally extra spaces to line things up, but so far we
have
> preferred to keep it with just +4.

Acknowledged.

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/static.dart
File pkg/smoke/lib/static.dart (right):

https://codereview.chromium.org/362043006/diff/20001/pkg/smoke/lib/static.dar...
pkg/smoke/lib/static.dart:77: a.putIfAbsent(key, () => {});
On 2014/07/23 20:37:13, Siggi Cherem (dart-lang) wrote:
> On 2014/07/23 20:05:02, jakemac wrote:
> > So is this not inserting a null? It seems like there must be some magic
going
> on
> > where its inserting a new object using the default constructor? Or maybe I
am
> > just missing something here.
> 
> Yeah, it's confusing because we have both => and {}, the {} here is an empty
> map. To be more precise:
> 
> () {}      // returns null
> () => null // equivalent closure.
> () => {}   // returns a new map :-)

haha tricky, I figured it had to be something I was missing.

[Siggi Cherem (dart-lang), 2014-07-25 00:32:15]

Committed patchset #3 manually as r38563 (presubmit successful).