Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 361643002: setConfig is deprecated, use setInfo or allocPixels instead (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, dcheng, derat+watch_chromium.org, kalyank, ozone-reviews_chromium.org, rjkroege, rsesek+watch_chromium.org, sadrul, tfarina, yusukes+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

setConfig is deprecated, use setInfo or allocPixels instead kPMColor_SkColorType -> kN32_SkColorType BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280863

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : don't call allocPixels+rowbytes yet (skia bug) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -162 lines) Patch
M ui/app_list/test/app_list_test_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/clipboard/clipboard.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/cursor/cursor_loader_x11_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/codec/png_codec.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gfx/codec/png_codec_unittest.cc View 3 3 chunks +4 lines, -6 lines 0 comments Download
M ui/gfx/color_analysis.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/color_analysis_unittest.cc View 9 chunks +11 lines, -21 lines 0 comments Download
M ui/gfx/color_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/icon_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M ui/gfx/image/image_skia_rep.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/image/image_util_unittest.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M ui/gfx/skbitmap_operations.cc View 11 chunks +16 lines, -19 lines 0 comments Download
M ui/gfx/skbitmap_operations_unittest.cc View 17 chunks +18 lines, -37 lines 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/caca/caca_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/controls/button/image_button_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/button/label_button_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/table/test_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/table_example.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/wm/core/image_grid_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
6 years, 5 months ago (2014-06-29 03:15:21 UTC) #1
reed1
need owner review for refactoring change
6 years, 5 months ago (2014-07-01 13:42:04 UTC) #2
darin (slow to review)
lgtm
6 years, 5 months ago (2014-07-01 15:09:59 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-01 15:31:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/361643002/40001
6 years, 5 months ago (2014-07-01 15:32:27 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-01 17:04:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/361643002/60001
6 years, 5 months ago (2014-07-01 17:04:51 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 19:26:39 UTC) #8
Message was sent while issue was closed. 
Change committed as 280863

Powered by Google App Engine
This is Rietveld 408576698