ui/base/resource/resource_bundle.cc - Issue 361643002: setConfig is deprecated, use setInfo or allocPixels instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/resource/resource_bundle.cc

Issue 361643002: setConfig is deprecated, use setInfo or allocPixels instead (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't call allocPixels+rowbytes yet (skia bug) Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/resource/resource_bundle.cc

diff --git a/ui/base/resource/resource_bundle.cc b/ui/base/resource/resource_bundle.cc

index f5a592d022124b541899548087c1f2d2b5facbad..1afd46a05cad24c07caa5fc0ea8b6f1540bb1a40 100644

--- a/ui/base/resource/resource_bundle.cc

+++ b/ui/base/resource/resource_bundle.cc

@@ -774,8 +774,7 @@ gfx::Image& ResourceBundle::GetEmptyImage() {

if (empty_image_.IsEmpty()) {

// The placeholder bitmap is bright red so people notice the problem.

SkBitmap bitmap;

- bitmap.setConfig(SkBitmap::kARGB_8888_Config, 32, 32);

- bitmap.allocPixels();

+ bitmap.allocN32Pixels(32, 32);

bitmap.eraseARGB(255, 255, 0, 0);

empty_image_ = gfx::Image::CreateFrom1xBitmap(bitmap);

}