Issue 361313002: Revert of Remove the AA requirement for selecting GrEffect-based clipping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361313002: Revert of Remove the AA requirement for selecting GrEffect-based clipping. (Closed)

Created:
6 years, 5 months ago by mtklein

Modified:
6 years, 5 months ago

Reviewers:
bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Remove the AA requirement for selecting GrEffect-based clipping. (https://codereview.chromium.org/367013003/) Reason for revert: We think this is breaking the roll. Original issue's description: > Remove the AA requirement for selecting GrEffect-based clipping. > > Also, optionally use the scissor for a bw clip rect element instead of an effect. > > Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11 > > Committed: https://skia.googlesource.com/skia/+/e9a729cb4d3f05b9c750dc1f63a9cc65b5659f04 TBR=robertphillips@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/217daa7ec592fc306edffb9fb2a3d8c7ebff8c2d

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -62 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	8 chunks	+13 lines, -50 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Remove the AA requirement for selecting GrEffect-based clipping.

6 years, 5 months ago (2014-07-02 19:54:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/361313002/1

6 years, 5 months ago (2014-07-02 19:55:17 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-02 19:55:25 UTC) #3

Message was sent while issue was closed.

Change committed as 217daa7ec592fc306edffb9fb2a3d8c7ebff8c2d