Small cleanups to ported QuicServer and dependencies

net/quic/quic_in_memory_cache.h

Index: net/quic/quic_in_memory_cache.h
diff --git a/net/quic/quic_in_memory_cache.h b/net/quic/quic_in_memory_cache.h
index e37ce2bdf9e9f6034df49418081d35b0f369b3bc..17b7032378f28b1a4572875914a53b97725b13c6 100644
--- a/net/quic/quic_in_memory_cache.h
+++ b/net/quic/quic_in_memory_cache.h
@@ -18,7 +18,8 @@ class GURL;
 
 namespace net {
 
-extern base::FilePath::StringType g_quic_in_memory_cache_dir;
+NET_EXPORT_PRIVATE extern base::FilePath::StringType*

[wtc, 2014/07/02 19:39:08]

The order probably doesn't matter, but please put "extern" before
"NET_EXPORT_PRIVATE". See the Microsoft example code at

http://msdn.microsoft.com/en-us/library/y4h7bcy6.aspx

Update: I see that you've reverted the two changes here (adding
NET_EXPORT_PRIVATE and changing g_quic_in_memory_cache_dir to a pointer).

+    g_quic_in_memory_cache_dir;
 
 namespace test {
 class QuicInMemoryCachePeer;
@@ -44,7 +45,7 @@ class QuicInMemoryCache {
     ~Response();
 
     SpecialResponseType response_type() const { return response_type_; }
-    const HttpResponseHeaders& headers() const { return *headers_; }
+    const HttpResponseHeaders* headers() const { return headers_.get(); }
     const base::StringPiece body() const { return base::StringPiece(body_); }
 
    private: