Small cleanups to ported QuicServer and dependencies

net/quic/quic_in_memory_cache.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_IN_MEMORY_CACHE_H_
 #define NET_QUIC_QUIC_IN_MEMORY_CACHE_H_
 
 #include <string>
 
 #include "base/containers/hash_tables.h"
 #include "base/file_util.h"
 #include "base/memory/singleton.h"
 #include "base/strings/string_piece.h"
 #include "net/http/http_response_headers.h"
 
 template <typename T> struct DefaultSingletonTraits;
 class GURL;
 
 namespace net {
 
-extern base::FilePath::StringType g_quic_in_memory_cache_dir;
+NET_EXPORT_PRIVATE extern base::FilePath::StringType*

[wtc, 2014/07/02 19:39:08]

The order probably doesn't matter, but please put "extern" before
"NET_EXPORT_PRIVATE". See the Microsoft example code at

http://msdn.microsoft.com/en-us/library/y4h7bcy6.aspx

Update: I see that you've reverted the two changes here (adding
NET_EXPORT_PRIVATE and changing g_quic_in_memory_cache_dir to a pointer).

+    g_quic_in_memory_cache_dir;
 
 namespace test {
 class QuicInMemoryCachePeer;
 }  // namespace
 
 class QuicServer;
 
 // In-memory cache for HTTP responses.
 // Reads from disk cache generated by:
 // `wget -p --save_headers <url>`
 class QuicInMemoryCache {
  public:
   enum SpecialResponseType {
     REGULAR_RESPONSE,  // Send the headers and body like a server should.
     CLOSE_CONNECTION,  // Close the connection (sending the close packet).
     IGNORE_REQUEST,    // Do nothing, expect the client to time out.
   };
 
   // Container for response header/body pairs.
   class Response {
    public:
     Response();
     ~Response();
 
     SpecialResponseType response_type() const { return response_type_; }
-    const HttpResponseHeaders& headers() const { return *headers_; }
+    const HttpResponseHeaders* headers() const { return headers_.get(); }
     const base::StringPiece body() const { return base::StringPiece(body_); }
 
    private:
     friend class QuicInMemoryCache;
 
     void set_headers(scoped_refptr<HttpResponseHeaders> headers) {
       headers_ = headers;
     }
     void set_body(base::StringPiece body) {
       body.CopyToString(&body_);
@@ skipping 47 matching lines @@
 
   // Cached responses.
   ResponseMap responses_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicInMemoryCache);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_IN_MEMORY_CACHE_H_