Issue 361006: Switch theme loading to use its own string....

Issue 361006: Switch theme loading to use its own string.... (Closed)

Created:
11 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, laforge

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Switch theme loading to use its own string. BUG=http://crbug.com/24177 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32934

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/theme_install_bubble_view.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/gtk/theme_install_bubble_view_gtk.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/theme_install_bubble_view.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Per discussion (probably just abandon this and send it out again when you want it).

11 years, 1 month ago (2009-11-04 17:08:32 UTC) #2

Avi (use Gerrit)

On 2009/11/04 17:08:32, Mark Mentovai wrote: > Per discussion (probably just abandon this and send ...

11 years, 1 month ago (2009-11-17 18:02:19 UTC) #3

Mark Mentovai

LGTM but cc laforge to tell us if we're safe to start landing things with ...

11 years, 1 month ago (2009-11-17 18:04:22 UTC) #4

laforge

It is not quite safe yet, 249 pretty bad in terms of stability. Kind Regards, ...

11 years, 1 month ago (2009-11-17 18:24:46 UTC) #5

Avi (use Gerrit)

Ouch. OK, I'll hold off for a little longer. Avi On Tue, Nov 17, 2009 ...

11 years, 1 month ago (2009-11-17 18:44:14 UTC) #6

Avi (use Gerrit)

On 2009/11/17 18:24:46, laforge wrote: > It is not quite safe yet, 249 pretty bad ...

11 years, 1 month ago (2009-11-24 17:04:52 UTC) #7

laforge

11 years, 1 month ago (2009-11-24 17:16:42 UTC) #8

If I recall the question, 249 has stabilized, we are not going to re-branch,
so it would be safe to land this on trunk.

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA

On Tue, Nov 24, 2009 at 9:04 AM, <avi@chromium.org> wrote:

> On 2009/11/17 18:24:46, laforge wrote:
>
>> It is not quite safe yet, 249 pretty bad in terms of stability.
>>
>
> Looking better yet?
>
>
> http://codereview.chromium.org/361006
>

Expand Messages | Collapse Messages