Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 360733002: Remove callers of deprecatedShadowAncestorNode (Closed)

Created:
6 years, 5 months ago by deepak.sa
Modified:
6 years, 5 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove callers of deprecatedShadowAncestorNode This patch removes callers of deprecatedShadowAncestorNode from DragController and ReplaceSelectionCommand. BUG=234099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177633

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated ReplaceSelectionCommand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
deepak.sa
Please have a look. Thanks!
6 years, 5 months ago (2014-06-30 15:13:48 UTC) #1
tkent
https://codereview.chromium.org/360733002/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp File Source/core/editing/ReplaceSelectionCommand.cpp (right): https://codereview.chromium.org/360733002/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp#newcode160 Source/core/editing/ReplaceSelectionCommand.cpp:160: Node* shadowAncestorNode = editableRoot->shadowHost(); Is it ok to ignore ...
6 years, 5 months ago (2014-06-30 23:35:50 UTC) #2
deepak.sa
https://codereview.chromium.org/360733002/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp File Source/core/editing/ReplaceSelectionCommand.cpp (right): https://codereview.chromium.org/360733002/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp#newcode160 Source/core/editing/ReplaceSelectionCommand.cpp:160: Node* shadowAncestorNode = editableRoot->shadowHost(); On 2014/06/30 23:35:50, tkent wrote: ...
6 years, 5 months ago (2014-07-01 05:45:25 UTC) #3
deepak.sa
I have uploaded a new patch. Please have a look. Thanks!
6 years, 5 months ago (2014-07-07 04:12:11 UTC) #4
tkent
lgtm
6 years, 5 months ago (2014-07-08 00:05:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/360733002/20001
6 years, 5 months ago (2014-07-08 00:05:54 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-08 01:14:49 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 01:55:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15792)
6 years, 5 months ago (2014-07-08 01:55:44 UTC) #9
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-08 01:57:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/360733002/20001
6 years, 5 months ago (2014-07-08 01:58:49 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-08 03:19:54 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 03:49:49 UTC) #13
Message was sent while issue was closed.
Change committed as 177633

Powered by Google App Engine
This is Rietveld 408576698