Source/core/editing/ReplaceSelectionCommand.cpp - Issue 360733002: Remove callers of deprecatedShadowAncestorNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 360733002: Remove callers of deprecatedShadowAncestorNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: updated ReplaceSelectionCommand Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 42fc520f9afce59ae8fa459c959f229b59952326..3bd6d94de71800399f5141c5e3cae6e8d8ad9095 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -157,7 +157,11 @@ ReplacementFragment::ReplacementFragment(Document* document, DocumentFragment* f

if (!editableRoot)

return;

- Node* shadowAncestorNode = editableRoot->deprecatedShadowAncestorNode();

+ Node* shadowAncestorNode;

+ if (editableRoot->isInShadowTree())

+ shadowAncestorNode = editableRoot->shadowHost();

+ else

+ shadowAncestorNode = editableRoot.get();

if (!editableRoot->getAttributeEventListener(EventTypeNames::webkitBeforeTextInserted) &&

// FIXME: Remove these checks once textareas and textfields actually register an event handler.

« no previous file with comments | « no previous file | Source/core/page/DragController.cpp » ('j') | no next file with comments »