Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: Tools/GardeningServer/scripts/garden-o-matic.js

Issue 360553005: Remove the Expected Failures tab (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix teh testsw Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/controllers.js ('k') | Tools/GardeningServer/scripts/model.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/garden-o-matic.js
diff --git a/Tools/GardeningServer/scripts/garden-o-matic.js b/Tools/GardeningServer/scripts/garden-o-matic.js
index 74c406ce065ef5fa82b5856cfe71adc12de6bed4..e9e2e741c578188f33a8b7359ee9ff4582de90d5 100644
--- a/Tools/GardeningServer/scripts/garden-o-matic.js
+++ b/Tools/GardeningServer/scripts/garden-o-matic.js
@@ -32,7 +32,6 @@ var g_updateTimerId = 0;
var g_buildersFailing = null;
var g_unexpectedFailuresController = null;
-var g_failuresController = null;
var g_nonLayoutTestFailureBuilders = null;
@@ -80,9 +79,6 @@ function update()
});
Promise.all([model.updateRecentCommits(), model.updateResultsByBuilder()]).then(function() {
- if (g_failuresController)
- g_failuresController.update();
-
updating.update('Analyzing test failures ...');
model.analyzeUnexpectedFailures(function(failureAnalysis, total) {
@@ -154,13 +150,6 @@ $(document).ready(function() {
unexpected.appendChild(g_info);
unexpected.appendChild(unexpectedFailuresView);
- var expected = onebar.expected();
- if (expected) {
- var failuresView = new ui.failures.List();
- g_failuresController = new controllers.ExpectedFailures(model.state, failuresView, onebarController);
- expected.appendChild(failuresView);
- }
-
update();
});
« no previous file with comments | « Tools/GardeningServer/scripts/controllers.js ('k') | Tools/GardeningServer/scripts/model.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698