Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: Tools/GardeningServer/scripts/controllers.js

Issue 360553005: Remove the Expected Failures tab (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix teh testsw Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/scripts/garden-o-matic.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/controllers.js
diff --git a/Tools/GardeningServer/scripts/controllers.js b/Tools/GardeningServer/scripts/controllers.js
index 3f2d63c1ed06d99004c289890143938e4d954a89..8cfb7feae8fdd4145d207283a95d4077e79a1b0e 100644
--- a/Tools/GardeningServer/scripts/controllers.js
+++ b/Tools/GardeningServer/scripts/controllers.js
@@ -82,42 +82,6 @@ controllers.ResultsDetails = base.extends(Object, {
}
});
-controllers.ExpectedFailures = base.extends(Object, {
- init: function(model, view, delegate)
- {
- this._model = model;
- this._view = view;
- this._delegate = delegate;
- },
- update: function()
- {
- var expectedFailures = results.expectedFailuresByTest(this._model.resultsByBuilder);
- var failingTestsList = Object.keys(expectedFailures);
-
- $(this._view).empty();
- base.forEachDirectory(failingTestsList, function(label, testsFailingInDirectory) {
- var listItem = new ui.failures.ListItem(label, testsFailingInDirectory);
- this._view.appendChild(listItem);
- $(listItem).bind('examine', function() {
- this.onExamine(testsFailingInDirectory);
- }.bind(this));
- }.bind(this));
- },
- onExamine: function(failingTestsList)
- {
- var resultsView = new ui.results.View({
- fetchResultsURLs: results.fetchResultsURLs
- });
- var failuresByTest = base.filterDictionary(
- results.expectedFailuresByTest(this._model.resultsByBuilder),
- function(key) {
- return failingTestsList.indexOf(key) != -1;
- });
- var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
- this._delegate.showResults(resultsView);
- }
-});
-
var FailureStreamController = base.extends(Object, {
_resultsFilter: null,
_keyFor: function(failureAnalysis) { throw "Not implemented!"; },
« no previous file with comments | « no previous file | Tools/GardeningServer/scripts/garden-o-matic.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698