Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 360493003: Re-enable screen_orientation/ tests following mock fixes. (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 5 months ago
Reviewers:
Inactive
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Re-enable screen_orientation/ tests following mock fixes. The screen orientation mock was broken and some LayoutTests had to be disabled. Now that https://codereview.chromium.org/339913002 has landed, we the disabled tests should be working again. BUG=389047, 388748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mlamouri (slow - plz ping)
6 years, 5 months ago (2014-06-27 13:13:47 UTC) #1
mlamouri (slow - plz ping)
(ignore that comment, this is testing my filters)
6 years, 5 months ago (2014-06-28 08:32:05 UTC) #2
Inactive
lgtm
6 years, 5 months ago (2014-06-28 11:09:44 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 5 months ago (2014-06-28 23:43:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/360493003/1
6 years, 5 months ago (2014-06-28 23:43:51 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 23:46:33 UTC) #6
Message was sent while issue was closed.
Change committed as 177169

Powered by Google App Engine
This is Rietveld 408576698