Move MockScreenOrientationController to content/shell/renderer/test_runner/

Move MockScreenOrientationController to content/shell/renderer/test_runner/

Move MockScreenOrientationController to content/shell/renderer/test_runner/ and
have it implement the blink::WebScreenOrientationClient API so that locking /
unlocking works from layout tests.

R=mlamouri@chromium.org, jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280209

[Inactive, 2014-06-17 17:29:04]

Mounir, is this what you had in mind overall? I tried to follow your advice and
move the mock controller as suggested. However, the mock controller should no
longer interact directly with RenderViewImpl and therefore, I am not quite sure
how I can update the orientation and notify blink of the change. Do you have an
idea?

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_screen_orientation_controller.cc
(right):

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_screen_orientation_controller.cc:48:
static_cast<RenderViewImpl*>(render_view_)
This is a layering violation. I don't know how to avoid it at this point and I
am not very familiar with this part of the code. Any help on this would be
appreciated.

[mlamouri (slow - plz ping), 2014-06-18 13:47:42]

I'm not a big fan of the entire checking if the orientation is allowed by the
lock because a test depending on that would be testing the test code. I would
prefer to have basic calls in the test framework to change the orientation that
would then fire the right events and resolve the right promises.

https://codereview.chromium.org/339913002/diff/1/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/339913002/diff/1/content/content_shell.gypi#n...
content/content_shell.gypi:216:
'shell/renderer/test_runner/mock_screen_orientation_controller.h',
It should be mock_screen_orientation_client.{h,cc}

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_screen_orientation_controller.cc
(right):

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_screen_orientation_controller.cc:48:
static_cast<RenderViewImpl*>(render_view_)
On 2014/06/17 17:29:04, Chris Dumez wrote:
> This is a layering violation. I don't know how to avoid it at this point and I
> am not very familiar with this part of the code. Any help on this would be
> appreciated.

We could from the test_runner.cc notify the WebView that the orientation has
changed. However, reading the orientation will not produce the same result
because we use WebWidgetClient. It seems that this is not mocked. Would that be
a possible solution?

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_screen_orientation_controller.cc:113:
angle = -90;
Do not return negative values, please. This should be 270.

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_screen_orientation_controller.h
(right):

https://codereview.chromium.org/339913002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_screen_orientation_controller.h:18:
class MockScreenOrientationController
Can you call this MockScreenOrientationClient?

[mlamouri (slow - plz ping), 2014-06-25 14:55:36]

Chris, any update about this?

[Inactive, 2014-06-25 14:57:42]

On 2014/06/25 14:55:36, Mounir Lamouri wrote:
> Chris, any update about this?

Yes, I am working on this right now. I was on vacation and just came back today,
sorry.

The biggest problem is the layer violation. It seems mocking the orientation in
WebWidgetClient would be a workable solution. I'll look into this.

[mlamouri (slow - plz ping), 2014-06-25 15:01:17]

On 2014/06/25 at 14:57:42, ch.dumez wrote:
> On 2014/06/25 14:55:36, Mounir Lamouri wrote:
> > Chris, any update about this?
> 
> Yes, I am working on this right now. I was on vacation and just came back
today, sorry.
> 
> The biggest problem is the layer violation. It seems mocking the orientation
in WebWidgetClient would be a workable solution. I'll look into this.

Just for context, I'm nagging you because
https://codereview.chromium.org/336313011 broke some LayoutTests.

[Inactive, 2014-06-25 17:16:29]

Please take a look. I addressed the layer violation and the screen_orientation/
layout tests are passing.

[jochen (gone - plz use gerrit), 2014-06-26 14:56:20]

lgtm

[Inactive, 2014-06-27 00:20:38]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-27 00:21:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/339913002/40001

[commit-bot: I haz the power, 2014-06-27 02:28:12]

Change committed as 280209

[mlamouri (slow - plz ping), 2014-06-27 12:56:36]

FTR, LGTM

[Inactive, 2014-06-27 12:57:29]

On 2014/06/27 12:56:36, Mounir Lamouri wrote:
> FTR, LGTM

Great, thanks Mounir.