Replace 'ResourceRequest::TargetType' with 'ResourceRequest::RequestContext'.

Replace 'ResourceRequest::TargetType' with 'ResourceRequest::RequestContext'.

Fetch defines a variety of "request contexts", which Blink more or less
already models as either 'ResourceRequest::TargetType' or 'Resource::Type'.
These two enums more or less cover the same ground, but inconsistently
(even amongst themselves).

This patch is the first step towards a higher fidelity implementation of
Fetch's semantics. It replaces the 'TargetType' enum with a 'RequestContext'
enum, and sets up a temporary mapping in WebURLRequest which will be removed
once Chromium is updated with the new semantics.

A future patch will come up with some reasonable way of aligning
'Resource::Type' with the list of contexts.

BUG=390497
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177371

[Mike West, 2014-07-01 13:37:19]

Hey Adam, what do you think about this patch? Is it more or less the direction
you were pointing in with your comments on
https://codereview.chromium.org/356723003/?

Note that the contexts are still a bit in flux; I don't intend to land this
until folks from Mozilla comment on
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26247 and there's some indication
of alignment.

Thanks!

-mike

[abarth-chromium, 2014-07-01 14:50:54]

Yeah, this direction looks great.  Thanks!!

https://codereview.chromium.org/360233005/diff/1/Source/platform/network/Reso...
File Source/platform/network/ResourceRequest.h (right):

https://codereview.chromium.org/360233005/diff/1/Source/platform/network/Reso...
Source/platform/network/ResourceRequest.h:55: enum RequestContext {
We can just use blink::URLRequest::RequestContext directly.  There's no reason
to have two copies of the enum.

https://codereview.chromium.org/360233005/diff/1/public/platform/WebURLRequest.h
File public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/360233005/diff/1/public/platform/WebURLReques...
public/platform/WebURLRequest.h:93: UnspecifiedContext = 0,
The normal naming we use in the API would be:

RequestContextUnspecified
RequestContextAudio

etc

[Mike West, 2014-07-01 15:00:20]

I'll take care of these, thanks.

https://codereview.chromium.org/360233005/diff/1/Source/platform/network/Reso...
File Source/platform/network/ResourceRequest.h (right):

https://codereview.chromium.org/360233005/diff/1/Source/platform/network/Reso...
Source/platform/network/ResourceRequest.h:55: enum RequestContext {
On 2014/07/01 14:50:53, abarth wrote:
> We can just use blink::URLRequest::RequestContext directly.  There's no reason
> to have two copies of the enum.

One enum sounds great. That said, it looks like we wrap most enums when
exporting them; all the WebURLRequest enums are wrapping internal Blink enums so
far as I can tell. Is that just a historical artifact?

https://codereview.chromium.org/360233005/diff/1/public/platform/WebURLRequest.h
File public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/360233005/diff/1/public/platform/WebURLReques...
public/platform/WebURLRequest.h:93: UnspecifiedContext = 0,
On 2014/07/01 14:50:54, abarth wrote:
> The normal naming we use in the API would be:
> 
> RequestContextUnspecified
> RequestContextAudio
> 
> etc

Find and replace to the rescue!

[abarth-chromium, 2014-07-01 15:42:28]

On 2014/07/01 at 15:00:20, mkwst wrote:
> One enum sounds great. That said, it looks like we wrap most enums when
exporting them; all the WebURLRequest enums are wrapping internal Blink enums so
far as I can tell. Is that just a historical artifact?

Enums in public/platform don't need to be wrapped anymore.  We used to need to
do that because Apple didn't use public/platform.  Enums in public/web still
need to be wrapped in core because core can't depend on public/web.

[Mike West, 2014-07-01 16:14:40]

So, other than the fact that I missed a rename and nothing compiles, WDYT of the
patch? If I fix the rename, and the bots are happy, can I land it in the morning
when I'm back at a computer? :)

[abarth-chromium, 2014-07-01 17:15:30]

lgtm

[Mike West, 2014-07-02 07:17:42]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:18:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/360233005/40001

[commit-bot: I haz the power, 2014-07-02 08:06:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[Mike West, 2014-07-02 08:44:33]

The CQ bit was unchecked by mkwst@chromium.org

[Mike West, 2014-07-02 11:30:17]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-07-02 11:31:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/360233005/60001

[commit-bot: I haz the power, 2014-07-02 13:03:43]

Change committed as 177371