Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: Source/platform/exported/WebURLRequest.cpp

Issue 360233005: Replace 'ResourceRequest::TargetType' with 'ResourceRequest::RequestContext'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Uninitialized === crash. :( Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/xml/XMLHttpRequest.cpp ('k') | Source/platform/network/ResourceRequest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 void WebURLRequest::setReportRawHeaders(bool reportRawHeaders) 217 void WebURLRequest::setReportRawHeaders(bool reportRawHeaders)
218 { 218 {
219 m_private->m_resourceRequest->setReportRawHeaders(reportRawHeaders); 219 m_private->m_resourceRequest->setReportRawHeaders(reportRawHeaders);
220 } 220 }
221 221
222 bool WebURLRequest::reportRawHeaders() const 222 bool WebURLRequest::reportRawHeaders() const
223 { 223 {
224 return m_private->m_resourceRequest->reportRawHeaders(); 224 return m_private->m_resourceRequest->reportRawHeaders();
225 } 225 }
226 226
227 WebURLRequest::TargetType WebURLRequest::targetType() const 227 WebURLRequest::RequestContext WebURLRequest::requestContext() const
228 { 228 {
229 // FIXME: Temporary special case until downstream chromium.org knows of the new TargetTypes. 229 return m_private->m_resourceRequest->requestContext();
230 TargetType targetType = static_cast<TargetType>(m_private->m_resourceRequest ->targetType());
231 if (targetType == TargetIsTextTrack || targetType == TargetIsUnspecified)
232 return TargetIsSubresource;
233 return targetType;
234 } 230 }
235 231
236 WebReferrerPolicy WebURLRequest::referrerPolicy() const 232 WebReferrerPolicy WebURLRequest::referrerPolicy() const
237 { 233 {
238 return static_cast<WebReferrerPolicy>(m_private->m_resourceRequest->referrer Policy()); 234 return static_cast<WebReferrerPolicy>(m_private->m_resourceRequest->referrer Policy());
239 } 235 }
240 236
241 void WebURLRequest::addHTTPOriginIfNeeded(const WebString& origin) 237 void WebURLRequest::addHTTPOriginIfNeeded(const WebString& origin)
242 { 238 {
243 m_private->m_resourceRequest->addHTTPOriginIfNeeded(origin); 239 m_private->m_resourceRequest->addHTTPOriginIfNeeded(origin);
244 } 240 }
245 241
246 bool WebURLRequest::hasUserGesture() const 242 bool WebURLRequest::hasUserGesture() const
247 { 243 {
248 return m_private->m_resourceRequest->hasUserGesture(); 244 return m_private->m_resourceRequest->hasUserGesture();
249 } 245 }
250 246
251 void WebURLRequest::setHasUserGesture(bool hasUserGesture) 247 void WebURLRequest::setHasUserGesture(bool hasUserGesture)
252 { 248 {
253 m_private->m_resourceRequest->setHasUserGesture(hasUserGesture); 249 m_private->m_resourceRequest->setHasUserGesture(hasUserGesture);
254 } 250 }
255 251
256 void WebURLRequest::setTargetType(TargetType targetType) 252 void WebURLRequest::setRequestContext(RequestContext requestContext)
257 { 253 {
258 m_private->m_resourceRequest->setTargetType( 254 m_private->m_resourceRequest->setRequestContext(requestContext);
259 static_cast<ResourceRequest::TargetType>(targetType));
260 } 255 }
261 256
262 int WebURLRequest::requestorID() const 257 int WebURLRequest::requestorID() const
263 { 258 {
264 return m_private->m_resourceRequest->requestorID(); 259 return m_private->m_resourceRequest->requestorID();
265 } 260 }
266 261
267 void WebURLRequest::setRequestorID(int requestorID) 262 void WebURLRequest::setRequestorID(int requestorID)
268 { 263 {
269 m_private->m_resourceRequest->setRequestorID(requestorID); 264 m_private->m_resourceRequest->setRequestorID(requestorID);
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 { 339 {
345 // Subclasses may call this directly so a self-assignment check is needed 340 // Subclasses may call this directly so a self-assignment check is needed
346 // here as well as in the public assign method. 341 // here as well as in the public assign method.
347 if (m_private == p) 342 if (m_private == p)
348 return; 343 return;
349 if (m_private) 344 if (m_private)
350 m_private->dispose(); 345 m_private->dispose();
351 m_private = p; 346 m_private = p;
352 } 347 }
353 348
349 WebURLRequest::RequestContext WebURLRequest::requestContextFromTargetType(WebURL Request::TargetType targetType)
350 {
351 switch (targetType) {
352 case TargetIsMainFrame:
353 return RequestContextDocument;
354 case TargetIsSubframe:
355 return RequestContextChildDocument;
356 case TargetIsSubresource:
357 return RequestContextSubresource;
358 case TargetIsStyleSheet:
359 return RequestContextStyle;
360 case TargetIsScript:
361 return RequestContextScript;
362 case TargetIsFontResource:
363 return RequestContextFont;
364 case TargetIsImage:
365 return RequestContextImage;
366 case TargetIsObject:
367 return RequestContextObject;
368 case TargetIsMedia:
369 // FIXME: Split this out.
370 return RequestContextVideo;
371 case TargetIsWorker:
372 return RequestContextWorker;
373 case TargetIsSharedWorker:
374 return RequestContextSharedWorker;
375 case TargetIsPrefetch:
376 return RequestContextPrefetch;
377 case TargetIsFavicon:
378 return RequestContextFavicon;
379 case TargetIsXHR:
380 return RequestContextConnect;
381 case TargetIsTextTrack:
382 return RequestContextTextTrack;
383 case TargetIsPing:
384 return RequestContextPing;
385 case TargetIsServiceWorker:
386 return RequestContextServiceWorker;
387 case TargetIsUnspecified:
388 return RequestContextUnspecified;
389 }
390 ASSERT_NOT_REACHED();
391 return RequestContextSubresource;
392 }
393
394 WebURLRequest::TargetType WebURLRequest::targetTypeFromRequestContext(WebURLRequ est::RequestContext requestContext)
395 {
396 switch (requestContext) {
397 case RequestContextUnspecified:
398 return TargetIsUnspecified;
399 case RequestContextAudio:
400 return TargetIsMedia;
401 case RequestContextChildDocument:
402 return TargetIsSubframe;
403 case RequestContextConnect:
404 return TargetIsXHR;
405 case RequestContextDocument:
406 return TargetIsMainFrame;
407 case RequestContextDownload:
408 return TargetIsSubresource;
409 case RequestContextFavicon:
410 return TargetIsFavicon;
411 case RequestContextFont:
412 return TargetIsFontResource;
413 case RequestContextForm:
414 return TargetIsMainFrame;
415 case RequestContextImage:
416 return TargetIsImage;
417 case RequestContextManifest:
418 return TargetIsSubresource;
419 case RequestContextObject:
420 return TargetIsObject;
421 case RequestContextObjectRequest:
422 return TargetIsSubresource;
423 case RequestContextPing:
424 return TargetIsPing;
425 case RequestContextPrefetch:
426 return TargetIsPrefetch;
427 case RequestContextScript:
428 return TargetIsScript;
429 case RequestContextServiceWorker:
430 return TargetIsServiceWorker;
431 case RequestContextSharedWorker:
432 return TargetIsSharedWorker;
433 case RequestContextStyle:
434 return TargetIsStyleSheet;
435 case RequestContextSubresource:
436 return TargetIsSubresource;
437 case RequestContextTextTrack:
438 return TargetIsTextTrack;
439 case RequestContextVideo:
440 return TargetIsMedia;
441 case RequestContextWorker:
442 return TargetIsWorker;
443 }
444 ASSERT_NOT_REACHED();
445 return TargetIsSubresource;
446 }
447
448 // FIXME: Drop these two methods once embedders are updated to use RequestContex ts.
449 WebURLRequest::TargetType WebURLRequest::targetType() const
450 {
451 // FIXME: Temporary special case until downstream chromium.org knows of the new TargetTypes.
452 TargetType targetType = WebURLRequest::targetTypeFromRequestContext(requestC ontext());
453 if (targetType == TargetIsTextTrack || targetType == TargetIsUnspecified)
454 return TargetIsSubresource;
455 return targetType;
456 }
457
458 void WebURLRequest::setTargetType(TargetType targetType)
459 {
460 setRequestContext(WebURLRequest::requestContextFromTargetType(targetType));
461 }
462
463
354 } // namespace blink 464 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/xml/XMLHttpRequest.cpp ('k') | Source/platform/network/ResourceRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698