Don't put a text shadow on blue buttons in gtk theme mode.

Don't put a text shadow on blue buttons in gtk theme mode.

BUG=381541
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282271

[Evan Stade, 2014-06-30 22:53:38]

+Ben for native_theme and blue_button.cc
+erg for native_theme_gtk2.cc

[erg, 2014-06-30 23:57:51]

https://codereview.chromium.org/360123003/diff/1/chrome/browser/ui/libgtk2ui/...
File chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc (right):

https://codereview.chromium.org/360123003/diff/1/chrome/browser/ui/libgtk2ui/...
chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc:155: return
SK_ColorTRANSPARENT;
Instead of special casing this, can you just remove the NOTREACHED()?

[Evan Stade, 2014-07-01 00:19:07]

https://codereview.chromium.org/360123003/diff/1/chrome/browser/ui/libgtk2ui/...
File chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc (right):

https://codereview.chromium.org/360123003/diff/1/chrome/browser/ui/libgtk2ui/...
chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc:155: return
SK_ColorTRANSPARENT;
On 2014/06/30 23:57:51, erg wrote:
> Instead of special casing this, can you just remove the NOTREACHED()?

I don't think GdkColor supports transparency. Removing this shortcircuit and the
NOTREACHED() would mean the shadow is black.

[erg, 2014-07-01 00:20:17]

Huh. You're right. LGTM.

[Evan Stade, 2014-07-07 15:27:52]

ping Ben

[Ben Goodger (Google), 2014-07-08 15:42:59]

lgtm

[Evan Stade, 2014-07-08 17:52:37]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-08 17:55:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/360123003/1

[commit-bot: I haz the power, 2014-07-08 22:59:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-07-08 23:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 23:14:46]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Evan Stade, 2014-07-09 23:08:25]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-09 23:11:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/360123003/30001

[commit-bot: I haz the power, 2014-07-10 07:42:46]

Change committed as 282271