Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ui/views/controls/button/blue_button.cc

Issue 360123003: Don't put a text shadow on blue buttons in gtk theme mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/native_theme/native_theme.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/blue_button.cc
diff --git a/ui/views/controls/button/blue_button.cc b/ui/views/controls/button/blue_button.cc
index 6de1e18c37b34428833322a4b4a26e608281b664..94e1e340967ff89f9877d2fa9ff21203bac83985 100644
--- a/ui/views/controls/button/blue_button.cc
+++ b/ui/views/controls/button/blue_button.cc
@@ -9,13 +9,6 @@
#include "ui/gfx/sys_color_change_listener.h"
#include "ui/views/controls/button/label_button_border.h"
-namespace {
-
-// Default shadow color for the blue button.
-const SkColor kBlueButtonShadowColor = SkColorSetRGB(0x53, 0x8C, 0xEA);
-
-} // namespace
-
namespace views {
// static
@@ -42,9 +35,13 @@ void BlueButton::ResetColorsFromNativeTheme() {
SetTextColor(STATE_DISABLED, GetNativeTheme()->
GetSystemColor(ui::NativeTheme::kColorId_BlueButtonDisabledColor));
- // TODO(estade): this is not great on system themes.
- label()->set_shadows(gfx::ShadowValues(1,
- gfx::ShadowValue(gfx::Point(0, 1), 0, kBlueButtonShadowColor)));
+ label()->set_shadows(gfx::ShadowValues(
+ 1,
+ gfx::ShadowValue(
+ gfx::Point(0, 1),
+ 0,
+ GetNativeTheme()->GetSystemColor(
+ ui::NativeTheme::kColorId_BlueButtonShadowColor))));
}
}
« no previous file with comments | « ui/native_theme/native_theme.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698