Language tag for speech.

Language tag for speech.

This is the 3rd in a 4-sided patch to add language attribute support to speech input.

The other patches can be found here:
  1st - http://codereview.chromium.org/3615005/show
  2nd - https://bugs.webkit.org/show_bug.cgi?id=47089
  4th - https://bugs.webkit.org/show_bug.cgi?id=47420

This patch will be submitted once the webkit change has been rolled into chromium DEPS. Also, a last webkit cleanup patch will be submitted at any point after the 2nd patch.

BUG=53598
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64466

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64596

[Leandro Graciá Gil, 2010-10-08 12:23:15]

On 2010/10/08 11:30:41, Leandro Graciá Gil wrote:
> 

Not should have tried the bots... yet. My mistake, sorry.

[Leandro Graciá Gil, 2010-10-29 14:13:23]

Chromium-side patch for the speech attribute. Let's review this while the WebKit
patch rolls into DEPS.

Rebased and merged with the changes introduced by the grammar attribute.

[jorlow, 2010-10-29 14:26:09]

http://codereview.chromium.org/3595018/diff/14001/15009
File chrome/browser/speech/speech_recognizer.h (right):

http://codereview.chromium.org/3595018/diff/14001/15009#newcode76
chrome/browser/speech/speech_recognizer.h:76: SpeechRecognizer(Delegate*
delegate, int caller_id,
put all 4 on their own lines

http://codereview.chromium.org/3595018/diff/14001/15010
File chrome/browser/speech/speech_recognizer_unittest.cc (right):

http://codereview.chromium.org/3595018/diff/14001/15010#newcode26
chrome/browser/speech/speech_recognizer_unittest.cc:26: recognizer_(new
SpeechRecognizer(this, 1,
not indented correctly

http://codereview.chromium.org/3595018/diff/14001/15011
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3595018/diff/14001/15011#newcode2883
chrome/common/render_messages_internal.h:2883: std::string /* language tag */,
these should be like variable names...so language_tag  (please fix the above 2
as well)

http://codereview.chromium.org/3595018/diff/14001/15013
File chrome/renderer/speech_input_dispatcher.h (right):

http://codereview.chromium.org/3595018/diff/14001/15013#newcode17
chrome/renderer/speech_input_dispatcher.h:17: struct WebRect;
structs come after classes

[Satish, 2010-10-29 14:32:11]

http://codereview.chromium.org/3595018/diff/14001/15001
File chrome/browser/speech/speech_input_browsertest.cc (right):

http://codereview.chromium.org/3595018/diff/14001/15001#newcode50
chrome/browser/speech/speech_input_browsertest.cc:50: const std::string&
language_tag,
drop the '_tag' since you don't use it elsewhere

http://codereview.chromium.org/3595018/diff/14001/15002
File chrome/browser/speech/speech_input_dispatcher_host.cc (right):

http://codereview.chromium.org/3595018/diff/14001/15002#newcode144
chrome/browser/speech/speech_input_dispatcher_host.cc:144: const std::string&
language_tag,
drop the '_tag' since you don't use it elsewhere

http://codereview.chromium.org/3595018/diff/14001/15003
File chrome/browser/speech/speech_input_dispatcher_host.h (right):

http://codereview.chromium.org/3595018/diff/14001/15003#newcode49
chrome/browser/speech/speech_input_dispatcher_host.h:49: const std::string&
language_tag,
drop the '_tag' since you don't use it elsewhere

[Leandro Graciá Gil, 2010-10-29 14:44:27]

http://codereview.chromium.org/3595018/diff/14001/15001
File chrome/browser/speech/speech_input_browsertest.cc (right):

http://codereview.chromium.org/3595018/diff/14001/15001#newcode50
chrome/browser/speech/speech_input_browsertest.cc:50: const std::string&
language_tag,
On 2010/10/29 14:32:11, Satish wrote:
> drop the '_tag' since you don't use it elsewhere

Done.

http://codereview.chromium.org/3595018/diff/14001/15002
File chrome/browser/speech/speech_input_dispatcher_host.cc (right):

http://codereview.chromium.org/3595018/diff/14001/15002#newcode144
chrome/browser/speech/speech_input_dispatcher_host.cc:144: const std::string&
language_tag,
On 2010/10/29 14:32:11, Satish wrote:
> drop the '_tag' since you don't use it elsewhere

Done.

http://codereview.chromium.org/3595018/diff/14001/15003
File chrome/browser/speech/speech_input_dispatcher_host.h (right):

http://codereview.chromium.org/3595018/diff/14001/15003#newcode49
chrome/browser/speech/speech_input_dispatcher_host.h:49: const std::string&
language_tag,
On 2010/10/29 14:32:11, Satish wrote:
> drop the '_tag' since you don't use it elsewhere

Done.

http://codereview.chromium.org/3595018/diff/14001/15009
File chrome/browser/speech/speech_recognizer.h (right):

http://codereview.chromium.org/3595018/diff/14001/15009#newcode76
chrome/browser/speech/speech_recognizer.h:76: SpeechRecognizer(Delegate*
delegate, int caller_id,
On 2010/10/29 14:26:09, jorlow wrote:
> put all 4 on their own lines

Done.

http://codereview.chromium.org/3595018/diff/14001/15010
File chrome/browser/speech/speech_recognizer_unittest.cc (right):

http://codereview.chromium.org/3595018/diff/14001/15010#newcode26
chrome/browser/speech/speech_recognizer_unittest.cc:26: recognizer_(new
SpeechRecognizer(this, 1,
On 2010/10/29 14:26:09, jorlow wrote:
> not indented correctly

Done.

http://codereview.chromium.org/3595018/diff/14001/15011
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3595018/diff/14001/15011#newcode2883
chrome/common/render_messages_internal.h:2883: std::string /* language tag */,
On 2010/10/29 14:26:09, jorlow wrote:
> these should be like variable names...so language_tag  (please fix the above 2
> as well)

Done.

http://codereview.chromium.org/3595018/diff/14001/15013
File chrome/renderer/speech_input_dispatcher.h (right):

http://codereview.chromium.org/3595018/diff/14001/15013#newcode17
chrome/renderer/speech_input_dispatcher.h:17: struct WebRect;
On 2010/10/29 14:26:09, jorlow wrote:
> structs come after classes

Done.

[jorlow, 2010-10-29 14:52:56]

LGTM

http://codereview.chromium.org/3595018/diff/27001/28011
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3595018/diff/27001/28011#newcode2882
chrome/common/render_messages_internal.h:2882: gfx::Rect /* element rect in
render view coordinates */,
Like I said, fix these lines too please.

[Leandro Graciá Gil, 2010-10-29 15:14:39]

http://codereview.chromium.org/3595018/diff/27001/28011
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3595018/diff/27001/28011#newcode2882
chrome/common/render_messages_internal.h:2882: gfx::Rect /* element rect in
render view coordinates */,
On 2010/10/29 14:52:56, jorlow wrote:
> Like I said, fix these lines too please.

Done.

[Leandro Graciá Gil, 2010-10-29 21:04:12]

Fixed compile problem in unittest. Sorry, my fault for not doing a git try
before committing. I was waiting for the webkit roll and forgot about it.

[jorlow, 2010-11-01 08:49:00]

lgtm

On Fri, Oct 29, 2010 at 10:04 PM, <leandrogracia@chromium.org> wrote:

> Fixed compile problem in unittest. Sorry, my fault for not doing a git try
> before committing. I was waiting for the webkit roll and forgot about it.
>
>
> http://codereview.chromium.org/3595018/show
>