content/public/common/context_menu_params.h - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/context_menu_params.h

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed yoyo's comments, restricted items to relevant extension Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/context_menu_params.h

diff --git a/content/public/common/context_menu_params.h b/content/public/common/context_menu_params.h

index ccef48ec2ca40b39fb42c817f097213e8383beda..f1bfb02847a7fd215b004da138cee9259f07f3e4 100644

--- a/content/public/common/context_menu_params.h

+++ b/content/public/common/context_menu_params.h

@@ -141,6 +141,8 @@ struct CONTENT_EXPORT ContextMenuParams {

ui::MenuSourceType source_type;

+ std::string extension_id;

Devlin 2014/07/01 20:54:24 This is a layering violation - src/content should

gpdavis 2014/07/02 01:17:47 I actually think I don't need this anymore, so I'l

#if defined(OS_ANDROID)

// Points representing the coordinates in the document space of the start and

// end of the selection, if there is one.

« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/common/extensions/api/web_view_internal.json ('k') | no next file » | no next file with comments »