chrome/browser/extensions/menu_manager.cc - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed yoyo's comments, restricted items to relevant extension Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_context_menu_model.cc ('K') | « chrome/browser/extensions/menu_manager.h ('k') | chrome/common/extensions/api/context_menus.json » ('j') | content/public/common/context_menu_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager.cc

diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc

index e40b467272de299a68791f42f416c93720d44a96..62bd2e75c6f23b242a196983aaebecd2be85d4ef 100644

--- a/chrome/browser/extensions/menu_manager.cc

+++ b/chrome/browser/extensions/menu_manager.cc

@@ -661,6 +661,9 @@ void MenuManager::ExecuteCommand(Profile* profile,

webview_guest->view_instance_id());

}

+ if (params.extension_id.length() > 0)

Devlin 2014/07/01 20:54:24 nit: prefer "!params.extension_id.empty()"

+ properties->SetString("extension_id", params.extension_id);

Devlin 2014/07/01 20:54:24 it looks like we prefer camelCaseStyle for these k

args->Append(properties);

// Add the tab info to the argument list.