chrome/browser/extensions/menu_manager_factory.h - Issue 359493005: Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager_factory.h

Issue 359493005: Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup, minor unittest refactor Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_context_menu_model_unittest.cc ('K') | « chrome/browser/extensions/menu_manager.h ('k') | chrome/browser/extensions/menu_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager_factory.h

diff --git a/chrome/browser/extensions/menu_manager_factory.h b/chrome/browser/extensions/menu_manager_factory.h

index cdfdfa4601c7dc4e733d775a745feb5609111fc4..554c03313ec77a3c25ac6ebd401e43265a8afa00 100644

--- a/chrome/browser/extensions/menu_manager_factory.h

+++ b/chrome/browser/extensions/menu_manager_factory.h

@@ -24,6 +24,7 @@ class MenuManagerFactory : public BrowserContextKeyedServiceFactory {

private:

friend struct DefaultSingletonTraits<MenuManagerFactory>;

+ friend class ExtensionContextMenuModelTest;

Devlin 2014/07/30 21:32:58 Why do we still need this? What about Yoyo's idea

Yoyo Zhou 2014/07/30 21:49:33 This slightly reduces code duplication, so I think

Devlin 2014/07/30 21:54:15 Could we instead wrap the call to BuildServiceInst

gpdavis 2014/07/31 23:11:28 That seems reasonable to me. Done.

MenuManagerFactory();

virtual ~MenuManagerFactory();