Extend contextMenus API to support browser/page actions

chrome/browser/extensions/menu_manager_factory.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_MENU_MANAGER_FACTORY_H_
 #define CHROME_BROWSER_EXTENSIONS_MENU_MANAGER_FACTORY_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
 namespace content {
 class BrowserContext;
 }
 
 namespace extensions {
 class MenuManager;
 
 class MenuManagerFactory : public BrowserContextKeyedServiceFactory {
  public:
   static MenuManager* GetForBrowserContext(content::BrowserContext* context);
 
   static MenuManagerFactory* GetInstance();
 
  private:
   friend struct DefaultSingletonTraits<MenuManagerFactory>;
+  friend class ExtensionContextMenuModelTest;

[Devlin, 2014/07/30 21:32:58]

Why do we still need this?  What about Yoyo's idea of just constructing the
MenuManager explicitly in the test?

[Yoyo Zhou, 2014/07/30 21:49:33]

This slightly reduces code duplication, so I think it's fine.

[Devlin, 2014/07/30 21:54:15]

Could we instead wrap the call to BuildServiceInstanceFor() in a ForTest method
then, so that future tests can use it instead of adding to the friend list?

[gpdavis, 2014/07/31 23:11:28]

That seems reasonable to me.  Done.

 
   MenuManagerFactory();
   virtual ~MenuManagerFactory();
 
   virtual KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* context) const OVERRIDE;
   virtual content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const OVERRIDE;
   virtual bool ServiceIsCreatedWithBrowserContext() const OVERRIDE;
   virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_MENU_MANAGER_FACTORY_H_