Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: ui/chromeos/touch_exploration_controller_unittest.cc

Issue 359453003: Added accurate TouchToMouseMode testing to SplitTap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: An old and new test that fail without the new added line. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/chromeos/touch_exploration_controller_unittest.cc
diff --git a/ui/chromeos/touch_exploration_controller_unittest.cc b/ui/chromeos/touch_exploration_controller_unittest.cc
index 86582f0ff06b5bc06698b094700dc7c677d3e52e..13d6423939ad2be8f5627ff0dd6d4e90af0c0ea1 100644
--- a/ui/chromeos/touch_exploration_controller_unittest.cc
+++ b/ui/chromeos/touch_exploration_controller_unittest.cc
@@ -790,10 +790,13 @@ TEST_F(TouchExplorationTest, SplitTap) {
ui::TouchEvent split_tap_press(
ui::ET_TOUCH_PRESSED, second_touch_location, 1, Now());
generator_->Dispatch(&split_tap_press);
+ cursor_client()->DisableMouseEvents();
mfomitchev 2014/06/27 16:36:05 A comment explaining that we are simulating the be
tdanderson 2014/06/27 17:01:07 I'd also mention that you've added the browser tes
evy 2014/06/27 18:03:00 Done.
evy 2014/06/27 18:03:00 Done.
+ cursor_client()->HideCursor();
mfomitchev 2014/06/27 16:36:05 You can probably get rid of HideCursor() since lik
evy 2014/06/27 18:03:00 Done.
ui::TouchEvent split_tap_release(
ui::ET_TOUCH_RELEASED, second_touch_location, 1, Now());
generator_->Dispatch(&split_tap_release);
EXPECT_FALSE(IsInNoFingersDownState());
+ EXPECT_TRUE(IsInTouchToMouseMode());
mfomitchev 2014/06/27 16:36:05 Comment: Releasing the second finger should re-ena
evy 2014/06/27 18:03:00 Done.
const ScopedVector<ui::LocatedEvent>& captured_events = GetCapturedEvents();
ASSERT_EQ(2U, captured_events.size());

Powered by Google App Engine
This is Rietveld 408576698