Added accurate TouchToMouseMode testing to SplitTap

ui/chromeos/touch_exploration_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/chromeos/touch_exploration_controller.h"
 
 #include "base/test/simple_test_tick_clock.h"
 #include "base/time/time.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/test/aura_test_base.h"
@@ skipping 763 matching lines @@
 
   // Tap and hold at one location, and get a mouse move event in touch explore.
   EnterTouchExplorationModeAtLocation(initial_touch_location);
   std::vector<ui::LocatedEvent*> events =
       GetCapturedEventsOfType(ui::ET_MOUSE_MOVED);
   ASSERT_EQ(1U, events.size());
 
   EXPECT_EQ(initial_touch_location, events[0]->location());
   EXPECT_TRUE(events[0]->flags() & ui::EF_IS_SYNTHESIZED);
   EXPECT_TRUE(events[0]->flags() & ui::EF_TOUCH_ACCESSIBILITY);
   ClearCapturedEvents();

[mfomitchev, 2014/06/27 16:36:05]

Add EXPECT_TRUE(IsInTouchToMouseMode())

[evy, 2014/06/27 18:03:00]

Done.

 
   // Now tap and release at a different location. This should result in a
   // single touch and release at the location of the first (held) tap,
   // not at the location of the second tap and release.
   // After the release, there is still a finger in touch explore mode.
   ui::TouchEvent split_tap_press(
       ui::ET_TOUCH_PRESSED, second_touch_location, 1, Now());
   generator_->Dispatch(&split_tap_press);
+  cursor_client()->DisableMouseEvents();

[mfomitchev, 2014/06/27 16:36:05]

A comment explaining that we are simulating the behavior of the real device here
would be helpful.

[tdanderson, 2014/06/27 17:01:07]

I'd also mention that you've added the browser test
TouchExplorationTest.SplitTapExplore to test this without relying on manually
setting the state.

[evy, 2014/06/27 18:03:00]

Done.

[evy, 2014/06/27 18:03:00]

Done.

+  cursor_client()->HideCursor();

[mfomitchev, 2014/06/27 16:36:05]

You can probably get rid of HideCursor() since like you said it stays hidden all
along.

[evy, 2014/06/27 18:03:00]

Done.

   ui::TouchEvent split_tap_release(
       ui::ET_TOUCH_RELEASED, second_touch_location, 1, Now());
   generator_->Dispatch(&split_tap_release);
   EXPECT_FALSE(IsInNoFingersDownState());
+  EXPECT_TRUE(IsInTouchToMouseMode());

[mfomitchev, 2014/06/27 16:36:05]

Comment: Releasing the second finger should re-enable mouse events putting us
back into the touch exploration mode.

[evy, 2014/06/27 18:03:00]

Done.

 
   const ScopedVector<ui::LocatedEvent>& captured_events = GetCapturedEvents();
   ASSERT_EQ(2U, captured_events.size());
   EXPECT_EQ(ui::ET_TOUCH_PRESSED, captured_events[0]->type());
   EXPECT_EQ(initial_touch_location, captured_events[0]->location());
   EXPECT_EQ(ui::ET_TOUCH_RELEASED, captured_events[1]->type());
   EXPECT_EQ(initial_touch_location, captured_events[1]->location());
 }

[mfomitchev, 2014/06/27 16:36:05]

At the end of the test would be good to do the release of the first finger and
do EXPECT_TRUE(IsInNoFingersDownState());

[evy, 2014/06/27 18:03:00]

Done.

 
 // If split tap is started but the touch explore finger is released first,
 // there should still be a touch press and release sent to the location of
 // the last successful touch exploration.
 // Both fingers should be released after the click goes through.
 TEST_F(TouchExplorationTest, SplitTapRelease) {
   SwitchTouchExplorationMode(true);
 
   gfx::Point initial_touch_location(11, 12);
   gfx::Point second_touch_location(33, 34);
@@ skipping 168 matching lines @@
   base::TimeDelta pressed_time = captured_events[0]->time_stamp();
   EXPECT_EQ(ui::ET_TOUCH_RELEASED, captured_events[1]->type());
   EXPECT_EQ(initial_touch_location, captured_events[1]->location());
   base::TimeDelta released_time = captured_events[1]->time_stamp();
   EXPECT_EQ(gesture_detector_config_.longpress_timeout,
             released_time - pressed_time);
   EXPECT_TRUE(IsInNoFingersDownState());
 }
 
 }  // namespace ui