Issue 359443003: Don't pass in --revision into gclient sync on the DEPS sync in apply_issue.py if git

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 359443003: Don't pass in --revision into gclient sync on the DEPS sync in apply_issue.py if git (Closed)

Created:
6 years, 5 months ago by hinoka

Modified:
6 years, 5 months ago

Reviewers:
Ryan Tseng, iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, smut

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Don't pass in --revision into gclient sync on the DEPS sync in apply_issue.py if git We changed apply_issue to stage the patch if its on git, so it doesn't make sense to pass in --revision because that causes gclient to run solutions in managed mode. BUG=388374 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280855

Patch Set 1 #

Patch Set 2 : Remove that stray change #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	apply_issue.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/359443003/20001

6 years, 5 months ago (2014-07-01 18:46:25 UTC) #4

Message was sent while issue was closed.

Change committed as 280855

Expand Messages | Collapse Messages