Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2851)

Unified Diff: apply_issue.py

Issue 359443003: Don't pass in --revision into gclient sync on the DEPS sync in apply_issue.py if git (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Remove that stray change Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apply_issue.py
diff --git a/apply_issue.py b/apply_issue.py
index 801b0f17b9c88fdffad12ca5c017ac8e3c5e3483..8bcb3b2e55307f8817cb29be28bb94574bcb9f71 100755
--- a/apply_issue.py
+++ b/apply_issue.py
@@ -235,17 +235,17 @@ def main():
print(
'A DEPS file was updated inside a gclient checkout, running gclient '
'sync.')
- base_rev = 'BASE' if scm_type == 'svn' else 'HEAD'
gclient_path = os.path.join(BASE_DIR, 'gclient')
if sys.platform == 'win32':
gclient_path += '.bat'
with annotated_gclient.temp_filename(suffix='gclient') as f:
cmd = [
gclient_path, 'sync',
- '--revision', base_rev,
'--nohooks',
'--delete_unversioned_trees',
]
+ if scm_type == 'svn':
+ cmd.extend(['--revision', 'BASE'])
if options.revision_mapping:
cmd.extend(['--output-json', f])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698