Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 359023002: Remove CSS Exclusions leftovers (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-css, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rune+blink, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove CSS Exclusions leftovers https://codereview.chromium.org/60013004 started this but must have missed these. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177167

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix some issues #

Patch Set 3 : Fix tests #

Patch Set 4 : Fix one more test #

Patch Set 5 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -357 lines) Patch
D LayoutTests/fast/exclusions/parsing/parsing-wrap-flow.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/exclusions/parsing/parsing-wrap-flow-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/exclusions/parsing/parsing-wrap-through.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/exclusions/parsing/parsing-wrap-through-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/exclusions/parsing/script-tests/parsing-test-utils.js View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/fast/exclusions/parsing/script-tests/parsing-wrap-flow.js View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/exclusions/parsing/script-tests/parsing-wrap-through.js View 1 chunk +0 lines, -32 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 1 chunk +0 lines, -80 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 4 2 chunks +1 line, -13 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Bem Jones-Bey (adobe)
https://codereview.chromium.org/359023002/diff/1/Source/core/css/CSSValueKeywords.in File Source/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/359023002/diff/1/Source/core/css/CSSValueKeywords.in#newcode889 Source/core/css/CSSValueKeywords.in:889: wrap Why is this left here? Is it used ...
6 years, 5 months ago (2014-06-27 18:25:59 UTC) #1
rwlbuis
On 2014/06/27 18:25:59, Bem Jones-Bey (adobe) wrote: > https://codereview.chromium.org/359023002/diff/1/Source/core/css/CSSValueKeywords.in > File Source/core/css/CSSValueKeywords.in (right): > > ...
6 years, 5 months ago (2014-06-27 18:28:35 UTC) #2
Bem Jones-Bey (adobe)
lgtm
6 years, 5 months ago (2014-06-27 20:34:37 UTC) #3
rwlbuis
PTAL.
6 years, 5 months ago (2014-06-27 20:54:31 UTC) #4
abarth-chromium
lgtm
6 years, 5 months ago (2014-06-27 21:55:23 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-06-27 21:57:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/359023002/60001
6 years, 5 months ago (2014-06-27 21:58:35 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-27 23:07:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 23:08:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/10666) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13226) mac_gpu ...
6 years, 5 months ago (2014-06-27 23:08:49 UTC) #10
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-06-28 02:39:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/359023002/60001
6 years, 5 months ago (2014-06-28 02:40:38 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-28 02:45:16 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-28 02:46:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22826)
6 years, 5 months ago (2014-06-28 02:46:38 UTC) #15
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-06-28 20:24:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/359023002/80001
6 years, 5 months ago (2014-06-28 20:25:33 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-28 21:32:25 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 22:44:10 UTC) #19
Message was sent while issue was closed.
Change committed as 177167

Powered by Google App Engine
This is Rietveld 408576698