Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 60013004: Remove setCSSExclusionsEnabled(true) from CSS Shapes-Regions tests (Closed)

Created:
7 years, 1 month ago by Zoltan
Modified:
7 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews
Visibility:
Public.

Description

Remove setCSSExclusionsEnabled(true) from CSS Shapes-Regions tests Shapes are enabled by default when running tests, so the calls to internal settings can be removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -80 lines) Patch
M LayoutTests/fast/regions/shape-inside/shape-inside-on-additional-regions.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-first-region-block-content.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-second-region-block-content.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-recursive-layout.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-with-region-borders.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-with-region-padding.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
LGTM, rs=me!
7 years, 1 month ago (2013-11-05 23:48:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/60013004/1
7 years, 1 month ago (2013-11-05 23:51:00 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=15733
7 years, 1 month ago (2013-11-06 01:26:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/60013004/1
7 years, 1 month ago (2013-11-06 01:27:27 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 02:41:54 UTC) #5
Message was sent while issue was closed.
Change committed as 161412

Powered by Google App Engine
This is Rietveld 408576698