Navigation transitions: Pass is_transition_navigation flag up to the embedder

content/browser/frame_host/navigation_entry_impl.h

Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index 613f45edb42b039a7f1d1a2a6830610a60c8e4f6..33f2cf4d4d08119ba1f87e764fef571550cf9bd4 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -89,6 +89,9 @@ class CONTENT_EXPORT NavigationEntryImpl
   virtual void SetRedirectChain(const std::vector<GURL>& redirects) OVERRIDE;
   virtual const std::vector<GURL>& GetRedirectChain() const OVERRIDE;
   virtual bool IsRestored() const OVERRIDE;
+  virtual void SetIsTransitionNavigation(bool is_transition_navigation)

[nasko, 2014/07/03 09:39:30]

Does this mean that both forward and backwards navigations will have to use
transitions?

[oystein (OOO til 10th of July), 2014/07/17 17:52:49]

Hm, ideally not. The reason for this flag being in NavigationEntry was to
preserve it for cross-process navigations (so
NavigatorImpl::DidStartProvisionalLoad can pick it up again); is there a better
place to store this? I could clear it once it's "used", but that doesn't feel
too clean.

+      OVERRIDE;
+  virtual bool IsTransitionNavigation() OVERRIDE;
 
   // Once a navigation entry is committed, we should no longer track several
   // pieces of non-persisted state, as documented on the members below.
@@ -218,6 +221,10 @@ class CONTENT_EXPORT NavigationEntryImpl
     frame_tree_node_id_ = frame_tree_node_id;
   }
 
+  bool is_transition_navigation() const {
+    return is_transition_navigation_;
+  }
+
  private:
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
   // Session/Tab restore save portions of this class so that it can be recreated
@@ -338,6 +345,8 @@ class CONTENT_EXPORT NavigationEntryImpl
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
+  bool is_transition_navigation_;

[nasko, 2014/07/03 09:39:30]

Just like other places, this needs a comment.

+
   // Copy and assignment is explicitly allowed for this class.
 };