Navigation transitions: Pass is_transition_navigation flag up to the embedder

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "content/browser/site_instance_impl.h"
@@ skipping 71 matching lines @@
   virtual void SetExtraData(const std::string& key,
                             const base::string16& data) OVERRIDE;
   virtual bool GetExtraData(const std::string& key,
                             base::string16* data) const OVERRIDE;
   virtual void ClearExtraData(const std::string& key) OVERRIDE;
   virtual void SetHttpStatusCode(int http_status_code) OVERRIDE;
   virtual int GetHttpStatusCode() const OVERRIDE;
   virtual void SetRedirectChain(const std::vector<GURL>& redirects) OVERRIDE;
   virtual const std::vector<GURL>& GetRedirectChain() const OVERRIDE;
   virtual bool IsRestored() const OVERRIDE;
+  virtual void SetIsTransitionNavigation(bool is_transition_navigation)

[nasko, 2014/07/03 09:39:30]

Does this mean that both forward and backwards navigations will have to use
transitions?

[oystein (OOO til 10th of July), 2014/07/17 17:52:49]

Hm, ideally not. The reason for this flag being in NavigationEntry was to
preserve it for cross-process navigations (so
NavigatorImpl::DidStartProvisionalLoad can pick it up again); is there a better
place to store this? I could clear it once it's "used", but that doesn't feel
too clean.

+      OVERRIDE;
+  virtual bool IsTransitionNavigation() OVERRIDE;
 
   // Once a navigation entry is committed, we should no longer track several
   // pieces of non-persisted state, as documented on the members below.
   void ResetForCommit();
 
   void set_unique_id(int unique_id) {
     unique_id_ = unique_id;
   }
 
   // The SiteInstance tells us how to share sub-processes. This is a reference
@@ skipping 109 matching lines @@
 
   // Indicates which FrameTreeNode to navigate.  Currently only used if the
   // --site-per-process flag is passed.
   int64 frame_tree_node_id() const {
     return frame_tree_node_id_;
   }
   void set_frame_tree_node_id(int64 frame_tree_node_id) {
     frame_tree_node_id_ = frame_tree_node_id;
   }
 
+  bool is_transition_navigation() const {
+    return is_transition_navigation_;
+  }
+
  private:
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
   // Session/Tab restore save portions of this class so that it can be recreated
   // later. If you add a new field that needs to be persisted you'll have to
   // update SessionService/TabRestoreService and Android WebView
   // state_serializer.cc appropriately.
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
 
   // See the accessors above for descriptions.
   int unique_id_;
@@ skipping 100 matching lines @@
   // --site-per-process flag is passed.  It is cleared in |ResetForCommit|
   // because we only use it while the navigation is pending.
   // TODO(creis): Move this to FrameNavigationEntry.
   int64 frame_tree_node_id_;
 
   // Used to store extra data to support browser features. This member is not
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
+  bool is_transition_navigation_;

[nasko, 2014/07/03 09:39:30]

Just like other places, this needs a comment.

+
   // Copy and assignment is explicitly allowed for this class.
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_