Issue 358903002: Make perlin noise do CTM-correct scaling.

Issue 358903002: Make perlin noise do CTM-correct scaling. (Closed)

Created:
6 years, 6 months ago by Stephen White

Modified:
6 years, 5 months ago

Reviewers:
sugoi1, bsalomon, sugoi

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Make perlin noise do CTM-correct scaling. When drawing perlin noise, generate noise at the resolution determined by CTM, not by the resolution at construction time. This required moving the generation of PaintingData to getContext() and asNewEffect() for the raster and GPU paths, respectively. It also required adjusting the matrices used during rendering to be translate-only. Committed: https://skia.googlesource.com/skia/+/ca6a7c29452e13cf63bb4e225972065cbfe6e265

Patch Set 1 #

Patch Set 2 : Tweak GM #

Patch Set 3 : Fix local matrix offsets; add test suppressions #

Patch Set 4 : Win32 fix (do tile size rounding) #

Patch Set 5 : revert perlinnoise GM changes #

Patch Set 6 : Fix delete -> SkDELETE, add missing SkDELETE #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -83 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	include/effects/SkPerlinNoiseShader.h	View	1 2 3 4 5	4 chunks	+5 lines, -6 lines	0 comments	Download
M	src/effects/SkPerlinNoiseShader.cpp	View	1 2 3 4 5	18 chunks	+71 lines, -77 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

sugoi

On 2014/06/27 18:34:31, Stephen White wrote: > sugoi@: PTAL. Thanks! lgtm

6 years, 5 months ago (2014-06-27 18:38:45 UTC) #3

Stephen White

The CQ bit was unchecked by senorblanco@chromium.org

6 years, 5 months ago (2014-06-27 19:04:10 UTC) #5

bsalomon

On 2014/06/27 19:04:27, Stephen White wrote: > +bsalomon for header file changes. lgtm

6 years, 5 months ago (2014-06-27 19:50:24 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/358903002/100001

6 years, 5 months ago (2014-06-27 20:06:41 UTC) #9

commit-bot: I haz the power

6 years, 5 months ago (2014-06-27 20:35:58 UTC) #10

Message was sent while issue was closed.

Change committed as ca6a7c29452e13cf63bb4e225972065cbfe6e265

Expand Messages | Collapse Messages