Source/platform/graphics/Canvas2DImageBufferSurface.h - Issue 358893002: Use newImageSnapshot() to get an image from a Canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/Canvas2DImageBufferSurface.h

Issue 358893002: Use newImageSnapshot() to get an image from a Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Correcting bugs and use new cache mechanism from SkImage Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/BitmapPattern.cpp ('K') | « Source/platform/graphics/BitmapPattern.cpp ('k') | Source/platform/graphics/Canvas2DLayerBridge.h » ('j') | Source/platform/graphics/Image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/Canvas2DImageBufferSurface.h

diff --git a/Source/platform/graphics/Canvas2DImageBufferSurface.h b/Source/platform/graphics/Canvas2DImageBufferSurface.h

index 60aca9cb74c89a035337e383029974e5ce8d66c5..95a60daa987034d1d85df96b4524d45c76633ebf 100644

--- a/Source/platform/graphics/Canvas2DImageBufferSurface.h

+++ b/Source/platform/graphics/Canvas2DImageBufferSurface.h

@@ -31,6 +31,7 @@

#ifndef Canvas2DImageBufferSurface_h

#define Canvas2DImageBufferSurface_h

+#include "Image.h"

Justin Novosad 2014/07/29 14:56:52 Avoid unnecessary dependency in header -> use forw

Rémi Piotaix 2014/07/29 17:18:22 Done.

#include "platform/graphics/Canvas2DLayerBridge.h"

#include "platform/graphics/ImageBufferSurface.h"

@@ -64,6 +65,7 @@ public:

virtual void setIsHidden(bool hidden) OVERRIDE { m_layerBridge->setIsHidden(hidden); }

virtual void setImageBuffer(ImageBuffer* imageBuffer) OVERRIDE { m_layerBridge->setImageBuffer(imageBuffer); }

+ virtual PassRefPtr<SkImage> newImageSnapshot() const OVERRIDE { return m_layerBridge->newImageSnapshot(); }

Justin Novosad 2014/07/29 14:56:52 You will have to move implementation to .cpp if Im

Rémi Piotaix 2014/07/29 17:18:22 Canvas2DLayerBridge already include SkImage

private:

RefPtr<Canvas2DLayerBridge> m_layerBridge;

};