Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 35883006: Add debugging info for software compositor swap. (Closed)

Created:
7 years, 1 month ago by jbauman
Modified:
7 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, Ilya Sherman, jar (doing other things), miu+watch_chromium.org
Visibility:
Public.

Description

Add debugging info for software compositor swap. The ReceivedBadMessage has been getting hit in the wild, so add some extra histograms and CHECKS to try to find out why. BUG= R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230532

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_software_output_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/compositor_software_output_device.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/actions/chromeactions.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbauman
7 years, 1 month ago (2013-10-22 22:49:52 UTC) #1
piman
lgtm https://codereview.chromium.org/35883006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/35883006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1591 content/browser/renderer_host/render_widget_host_view_aura.cc:1591: host_->GetProcess()->ReceivedBadMessage(); TBH this could fail if we're out ...
7 years, 1 month ago (2013-10-23 00:10:14 UTC) #2
jbauman
On 2013/10/23 00:10:14, piman wrote: > lgtm > > https://codereview.chromium.org/35883006/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc > File content/browser/renderer_host/render_widget_host_view_aura.cc (right): > ...
7 years, 1 month ago (2013-10-23 00:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/35883006/1
7 years, 1 month ago (2013-10-23 00:27:43 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=89497
7 years, 1 month ago (2013-10-23 01:39:01 UTC) #5
jbauman
7 years, 1 month ago (2013-10-23 22:45:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r230532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698