LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html - Issue 358673003: [CSS Grid Layout] Avoid inserting grid items twice in the grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html

Issue 358673003: [CSS Grid Layout] Avoid inserting grid items twice in the grid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html b/LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..019f649a532532b06962c1722cc22713bcad6cbb

--- /dev/null

+++ b/LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html

@@ -0,0 +1,16 @@

+<body id=container>

+ <p>This test checks that adding a new grid item before an already existing item wrapped by an anonymous block does not crash under ASAN.</p>

Manuel Rego 2014/06/25 20:13:11 Actually you don't need an ASAN build, but a regul

svillar 2014/06/26 09:45:52 Yeah but the issue was detected with ASAN, and the

+ <div style="display: grid;">X</div>

+</body>

+<script type="text/javascript">

+ if (window.testRunner)

+ testRunner.dumpAsText();

+ document.addEventListener("DOMContentLoaded", crash, false);

+ function crash() {

+ document.designMode = 'on';

+ window.getSelection().selectAllChildren(container);

Manuel Rego 2014/06/25 20:13:11 Nit: I guess it's enough with select the children

svillar 2014/06/26 09:45:52 Sure, I'll switch to selecting the grid children.

+ document.execCommand("Italic", null);

+ }

+</script>

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')