LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html - Issue 358673003: [CSS Grid Layout] Avoid inserting grid items twice in the grid

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html

Issue 358673003: [CSS Grid Layout] Avoid inserting grid items twice in the grid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <body id=container>

	2 <p>This test checks that adding a new grid item before an already existing ite m wrapped by an anonymous block does not crash under ASAN.</p>
	Manuel Rego 2014/06/25 20:13:11 Actually you don't need an ASAN build, but a regul Actually you don't need an ASAN build, but a regular debug build will assert with: ASSERTION FAILED: !m_gridItemsIndexesMap.contains(child) svillar 2014/06/26 09:45:52 Yeah but the issue was detected with ASAN, and the Show quoted text On 2014/06/25 20:13:11, Manuel Rego wrote: > Actually you don't need an ASAN build, but a regular debug build will > assert with: > ASSERTION FAILED: !m_gridItemsIndexesMap.contains(child) Yeah but the issue was detected with ASAN, and the issue is not really the assertion but the heap after free, that's why I decided to mention it.
	3 <div style="display: grid;">X</div>

	4 </body>

	5 <script type="text/javascript">

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8

	9 document.addEventListener("DOMContentLoaded", crash, false);

	10

	11 function crash() {

	12 document.designMode = 'on';

	13 window.getSelection().selectAllChildren(container);
	Manuel Rego 2014/06/25 20:13:11 Nit: I guess it's enough with select the children Nit: I guess it's enough with select the children of the grid itself to reproduce the issue. I mean, you don't need to make italic the description paragraph. svillar 2014/06/26 09:45:52 Sure, I'll switch to selecting the grid children. Show quoted text On 2014/06/25 20:13:11, Manuel Rego wrote: > Nit: I guess it's enough with select the children of the grid itself to > reproduce the issue. I mean, you don't need to make italic the > description paragraph. Sure, I'll switch to selecting the grid children.
	14 document.execCommand("Italic", null);

	15 }

	16 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')