LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html - Issue 358673003: [CSS Grid Layout] Avoid inserting grid items twice in the grid

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html

Issue 358673003: [CSS Grid Layout] Avoid inserting grid items twice in the grid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch v2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <body>

	2 <p>This test checks that adding a new grid item before an already existing ite m wrapped by an anonymous block does not crash under ASAN.</p>

	3 <div id=grid style="display: grid;">X</div>
	Manuel Rego 2014/07/01 13:05:11 After https://codereview.chromium.org/333563003/ y After https://codereview.chromium.org/333563003/ you'll need to set grid-auto-flow to "stack" or the test won't crash (even without your patch). On the other hand, once "stack" implementation is done. We'll be marking the grid as dirty if it contains any auto-positioned item. In any of the auto-placement modes (sparse, dense or stack) we need to find an empty place to insert the auto-positioned items, so if the grid contains any of those, we have to dirty it in RenderGrid::addChild(). This means that this kind of tests won't do anything, as the grid is going to be marked as dirty when dealing with anonymous items (which always are auto-positioned). So, I'm not sure what's the best approach to carry on with these issues. Julien - ping for review 2014/07/07 17:34:41 It's fine to land this change and test case to ens Show quoted text On 2014/07/01 13:05:11, Manuel Rego wrote: > After https://codereview.chromium.org/333563003/ you'll need to set > grid-auto-flow to "stack" or the test won't crash (even without your patch). > > On the other hand, once "stack" implementation is done. We'll be marking > the grid as dirty if it contains any auto-positioned item. > In any of the auto-placement modes (sparse, dense or stack) we need to > find an empty place to insert the auto-positioned items, so if the grid > contains any of those, we have to dirty it in RenderGrid::addChild(). > > This means that this kind of tests won't do anything, as the grid is going > to be marked as dirty when dealing with anonymous items (which always > are auto-positioned). > > So, I'm not sure what's the best approach to carry on with these issues. It's fine to land this change and test case to ensure we don't regress (assuming it has the grid-auto-flow set to 'stack'). Even if we change the way we handle positioned elements, it makes sure we have some smoke-tests coverage and ensures that this very bug doesn't come back.
	4 </body>

	5 <script type="text/javascript">

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8

	9 document.addEventListener("DOMContentLoaded", crash, false);

	10

	11 function crash() {

	12 document.designMode = 'on';

	13 window.getSelection().selectAllChildren(grid);

	14 document.execCommand("Italic", null);

	15 }

	16 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt » ('j') | no next file with comments »